From db64b5bdc59d8a498b32ac5a99ffa5e572b49754 Mon Sep 17 00:00:00 2001
From: Marc Becker <becm@gmx.de>
Date: Sat, 25 Jan 2025 16:42:23 +0100
Subject: [PATCH] fix(bitbucket): detect expired OAuth credentials

fixes #1775
credentials MUST be valid for OAuth and/or BasicAuth modes
credentials SHOULD be considered invalid on auth mode mismatch
setting override exists to skip credential expiry checks
---
 src/shared/Atlassian.Bitbucket/BitbucketHostProvider.cs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/shared/Atlassian.Bitbucket/BitbucketHostProvider.cs b/src/shared/Atlassian.Bitbucket/BitbucketHostProvider.cs
index 286398de9..5723633be 100644
--- a/src/shared/Atlassian.Bitbucket/BitbucketHostProvider.cs
+++ b/src/shared/Atlassian.Bitbucket/BitbucketHostProvider.cs
@@ -443,11 +443,11 @@ private async Task<bool> ValidateCredentialsWork(InputArguments input, ICredenti
                     _context.Trace.WriteLine(message);
                     _context.Trace.WriteException(ex);
                     _context.Trace2.WriteError(message);
-                    return false;
                 }
             }
 
-            return true;
+            // auth refresh will handle expired token (or invalid authModes configuration)
+            return false;
         }
 
         private static string GetServiceName(Uri remoteUri)