Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make GPG Pass store path configurable by git config #1698

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Make GPG Pass store path configurable by git config #1698

merged 2 commits into from
Sep 30, 2024

Conversation

ipitsyn
Copy link
Contributor

@ipitsyn ipitsyn commented Sep 4, 2024

I found this change beneficial when using conditional git configuration includes for multiple git identities and pass password stores. It lets me transparently select appropriate password store without need to set its path explicitly by environment variable.
For example:

~/.config/git/config:

[user]
	name = John Doe
	email = [email protected]

[credential]
	credentialStore = gpg
	helper = /usr/local/bin/git-credential-manager
	gpgPassStorePath = /home/jdoe/.password-store

[includeIf "gitdir:~/Work/"]
	path = config.work

~/.config/git/config.work:

[user]
	name = John Doe (Umbrella Corp.)
	email = [email protected]

[credential]
	gpgPassStorePath = /home/jdoe/.password-store.umbrella

mjcheetham
mjcheetham requested changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@mjcheetham mjcheetham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great thanks! Please can you undo the change to the VERSION file, and also can I ask that you add a new section to the docs/config.md file for the new config setting entry?

VERSION Outdated
@@ -1 +1 @@
2.5.1.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this change to the VERSION file.. this is only updated by maintainers just before a release.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@Comanche85

This comment was marked as spam.

Sign in to view
@ipitsyn
Copy link
Contributor Author

ipitsyn commented Sep 9, 2024

Thanks @mjcheetham, requested has been done.

@mjcheetham
Copy link
Collaborator

Merging as broken links are not related to this PR.

Thanks for this contribution!

@mjcheetham mjcheetham merged commit 4e8e593 into git-ecosystem:main Sep 30, 2024
7 of 8 checks passed
@mjcheetham mjcheetham mentioned this pull request Sep 30, 2024
Merged
mjcheetham pushed a commit that referenced this pull request Sep 30, 2024
Release GCM 2.6 (#1712)
3c28096 
**Changes:**

- Drop no longer needed workflows (#1659)
- Documentation fixes (#1664, #1697)
- Configurable GPG store path via Git config (#1698)
- Fix Visual Studio build problems and update dependencies (#1711)
- Support sending X5C with certificate auth (#1666)
@github-actions github-actions bot mentioned this pull request Sep 30, 2024
Closed
@mdalaminak9089674532

This comment has been minimized.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Comanche85 Comanche85 Comanche85 left review comments

@tduckworth2 tduckworth2 tduckworth2 left review comments

@mjcheetham mjcheetham mjcheetham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ipitsyn @Comanche85 @mjcheetham @mdalaminak9089674532 @tduckworth2