Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect NO_PROXY environment variable / configuration #297

Closed
u1735067 opened this issue Feb 25, 2021 · 0 comments · Fixed by #299
Closed

Respect NO_PROXY environment variable / configuration #297

u1735067 opened this issue Feb 25, 2021 · 0 comments · Fixed by #299
Labels
enhancement New feature or request

Comments

@u1735067
Copy link

Feature description

Hello,

same report as in microsoft/Git-Credential-Manager-for-Windows#876, it appear there's no NO_PROXY support in GCMC (whatever the source is): https://github.com/microsoft/Git-Credential-Manager-Core/blob/v2.0.318-beta/src/shared/Microsoft.Git.CredentialManager/Settings.cs#L341

So git is properly handling requests, but GCMC can leaks informations through the proxy while it shouldn't.

Could GCMC handle this environment variable the same way gitdoes, which is https://curl.haxx.se/docs/manual.html (§Environment Variables, as per https://github.com/git/git/search?q=no_proxy&unscoped_q=no_proxy)?

Best,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant