Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up credential validation using password_expiry_utc attribute #1194

Closed
ldennington opened this issue Apr 10, 2023 Discussed in #1169 · 1 comment
Closed

Speed up credential validation using password_expiry_utc attribute #1194

ldennington opened this issue Apr 10, 2023 Discussed in #1169 · 1 comment
Labels
auth:oauth Specific to OAuth2 authentication enhancement New feature or request host:bitbucket Specific to the Bitbucket host provider host:generic Specific to the generic (basic/WIA) host provider host:gitlab Specific to the GitLab host provider

Comments

@ldennington
Copy link
Contributor

Discussed in #1169

As of Git 2.40, Git understands storage of password expiry. We can attempt to leverage this to reduce the need for token validation on every get request.

From the 2.40 release notes:

  • The credential subsystem learned that a password may have an
    explicit expiration.
@ldennington ldennington added enhancement New feature or request host:gitlab Specific to the GitLab host provider host:bitbucket Specific to the Bitbucket host provider host:generic Specific to the generic (basic/WIA) host provider labels Apr 10, 2023
@mjcheetham mjcheetham added the auth:oauth Specific to OAuth2 authentication label Apr 10, 2023
@ldennington
Copy link
Contributor Author

We actually already have a password expiry issue open (#268) - closing in favor of it

@ldennington ldennington closed this as not planned Won't fix, can't repro, duplicate, stale Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auth:oauth Specific to OAuth2 authentication enhancement New feature or request host:bitbucket Specific to the Bitbucket host provider host:generic Specific to the generic (basic/WIA) host provider host:gitlab Specific to the GitLab host provider
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mjcheetham @ldennington