-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support any OAuth server with custom config #1047
Comments
Great job! |
Thanks @hickford! This is something we've been talking about internally for awhile given the number of different Git hosts/forges that want GCM support via OAuth. In light of this, we've decided generic OAuth provider support would make sense here. We plan to have this complete in time for Git 2.40 release. |
Now that #1062 has been merged this means the next GCM release will include support for generic OAuth providers! |
Maybe the LOGO path configuration is missing? @mjcheetham |
Are you looking for a way to add custom branding/logos to the generic OAuth UI prompts? At the moment we don't plan to add support for customising the UI with branding. If you wanted to submit a PR adding the functionality we would consider it! Configuration pointing at either a local or remote file (URL) may be one acceptable method for this, but we'd want to be sure pulling external content from the Internet to be rendered was safe. |
Closing as this feature was released in 2.0.935 🎉 . |
To add OAuth support for a new forge requires around a thousand lines of code which has to be reviewed (example PRs: GitLab, Gitea, Gitee). Each new assembly adds megabytes to git-credential-manager binary size. Is any code necessary? All are similar OAuth implementations with only trivial differences in OAuth parameters.
Ideally you could use GCM with any generic OAuth forge with only simple config to specify the OAuth parameters, no code change necessary.
https://github.com/hickford/git-credential-oauth has this feature. Here's an example config for gitee.com:
The text was updated successfully, but these errors were encountered: