Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Controller 분리 (Chatbot, Mobile) #25

Open
kimtks456 opened this issue Feb 11, 2023 · 0 comments
Open

Controller 분리 (Chatbot, Mobile) #25

kimtks456 opened this issue Feb 11, 2023 · 0 comments
Labels
refactor Refactoring for readability of code

Comments

@kimtks456
Copy link
Contributor

@RequestMapping(path = "/meals", produces = "application/json;charset=UTF-8")

Spring에서 다른 controller들은 다른 RequestMapping path를 가져야 하므로 두 controller중 하나의 path를 바꿔야합니다.

  • MobileController의 path를 변경한다면, 현재 서비스중인 iOS 앱이 먹통이 되기에 정환님과 함께 동시에 배포가 진행되어야하므로 번거로울 수 있습니다. (추후 FE,BE 동시 배포하는걸 구축해야겠네요..)
  • ChatbotController의 path를 변경한다면, 카톡챗봇센터의 url만 바꿔주면 되므로 정환님과 동시배포할 필요 없습니다.

일단은 controller 분리는 주석처리 해둘게요! 코드리뷰때 회의해봐요!
kimtks456 pushed a commit that referenced this issue Feb 11, 2023
[#25] Refactor: rename Chatbot, Mobile logics
5488f1b
@kimtks456 kimtks456 added the refactor Refactoring for readability of code label Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor Refactoring for readability of code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kimtks456