From cd468fdedf651e308a74419bb9bfb2a128401c2c Mon Sep 17 00:00:00 2001 From: David Manthey Date: Thu, 1 Aug 2024 16:50:04 -0400 Subject: [PATCH] Don't redirect tile frame images via 303 They aren't rendered correctly. Apparently pulling in a 303 redirect on a texture image doesn't work as expected. --- CHANGELOG.md | 4 ++++ girder/girder_large_image/models/image_item.py | 5 +++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 96a481e99..eae6d4d34 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,10 @@ - Speed up checks for old annotations ([#1591](../../pull/1591)) - Improve plottable data endpoint to better fetch folder data ([#1594](../../pull/1594)) +### Bug Fixes + +- Don't redirect tile frame images via 303; they aren't rendered correctly ([#1596](../../pull/1596)) + ## 1.29.4 ### Improvements diff --git a/girder/girder_large_image/models/image_item.py b/girder/girder_large_image/models/image_item.py index 9c90332b3..9416cca50 100644 --- a/girder/girder_large_image/models/image_item.py +++ b/girder/girder_large_image/models/image_item.py @@ -410,7 +410,8 @@ def _getAndCacheImageOrData( if pickleCache: data = File().open(existing).read() return pickle.loads(data), 'application/octet-stream' - return File().download(existing, contentDisposition=contentDisposition) + return File().download(existing, contentDisposition=contentDisposition, + headers=kwargs.get('headers', True)) if checkAndCreate == 'check': return False return self.getAndCacheImageOrDataRun( @@ -563,7 +564,7 @@ def tileFrames(self, item, checkAndCreate='nosave', **kwargs): imageKey = 'tileFrames' return self._getAndCacheImageOrData( item, 'tileFrames', checkAndCreate, - dict(kwargs, imageKey=imageKey), **kwargs) + dict(kwargs, imageKey=imageKey), headers=False, **kwargs) def getPixel(self, item, **kwargs): """