-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Giraffe 6.2 is breaks against Microsoft.IO.RecyclableMemoryStream 3.0.0 #570
Comments
@dustinmoris @TheAngryByrd I proposed the PR #574 . How can I help you review and merge? |
@fpellet and others, there is a Giraffe maintenance issue that likely need to be resolved first before any PR:s can be reviewed and merged. See Dustin's tweet: https://twitter.com/dustinmoris/status/1749417442214883420 and the discussion ongoing in Oxpecker Lanayx/Oxpecker#4 |
Hello, Same issue here, any update on this? thanks |
Hi, I'll be looking into this problem during this week. |
Hi @da9l and @clement128, I have merged @fpellet's PR right now, and it's generating the pre-release version |
hi, thanks @64J0 looking good on my side |
Thanks for the fast reply. I'll close this issue as completed now! Great job @fpellet 👏🏼 👏🏼 👏🏼 |
It's possible to publish a new release (not release) ? |
Sure, I'll do that later today |
Done. |
When upgrading a project dependent of Giraffe 6.2 to .Net 8, one risks getting an exception in runtime due to unintended upgrade of Microsoft.IO.RecyclableMemoryStream to version 3.0.0
A System.MissingMethodException is thrown with the message:
Method not found: 'System.IO.MemoryStream Microsoft.IO.RecyclableMemoryStreamManager.GetStream(System.String)'.
Workaround:
Pin Microsoft.IO.RecyclableMemoryStream to 2.3.2
Suggested fix: Upgrade Giraffe to .Net 8 and the v3.0.0 of Microsoft.IO.RecyclableMemoryStream
The text was updated successfully, but these errors were encountered: