Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Giraffe 6.2 is breaks against Microsoft.IO.RecyclableMemoryStream 3.0.0 #570

Closed
da9l opened this issue Jan 18, 2024 · 11 comments · Fixed by #574
Closed

Giraffe 6.2 is breaks against Microsoft.IO.RecyclableMemoryStream 3.0.0 #570

da9l opened this issue Jan 18, 2024 · 11 comments · Fixed by #574
Assignees

Comments

@da9l
Copy link

da9l commented Jan 18, 2024

When upgrading a project dependent of Giraffe 6.2 to .Net 8, one risks getting an exception in runtime due to unintended upgrade of Microsoft.IO.RecyclableMemoryStream to version 3.0.0

A System.MissingMethodException is thrown with the message:
Method not found: 'System.IO.MemoryStream Microsoft.IO.RecyclableMemoryStreamManager.GetStream(System.String)'.

Workaround:
Pin Microsoft.IO.RecyclableMemoryStream to 2.3.2

Suggested fix: Upgrade Giraffe to .Net 8 and the v3.0.0 of Microsoft.IO.RecyclableMemoryStream

@fpellet
Copy link
Contributor

fpellet commented Jan 22, 2024

@dustinmoris @TheAngryByrd I proposed the PR #574 . How can I help you review and merge?

@da9l
Copy link
Author

da9l commented Jan 23, 2024

@fpellet and others, there is a Giraffe maintenance issue that likely need to be resolved first before any PR:s can be reviewed and merged. See Dustin's tweet: https://twitter.com/dustinmoris/status/1749417442214883420 and the discussion ongoing in Oxpecker Lanayx/Oxpecker#4

@clement128
Copy link

Hello, Same issue here, any update on this? thanks

@64J0
Copy link
Member

64J0 commented Mar 11, 2024

Hi, I'll be looking into this problem during this week.

@64J0
Copy link
Member

64J0 commented Mar 15, 2024

Hi @da9l and @clement128, I have merged @fpellet's PR right now, and it's generating the pre-release version 6.4.0-alpha-1. Can you please validate on your code if this new version is working correctly?

@clement128
Copy link

hi, thanks @64J0 looking good on my side

@da9l
Copy link
Author

da9l commented Mar 18, 2024

I have done some limited tests and they look good on my side too.
Thanks @64J0 & @fpellet !!

@64J0
Copy link
Member

64J0 commented Mar 18, 2024

Thanks for the fast reply. I'll close this issue as completed now! Great job @fpellet 👏🏼 👏🏼 👏🏼

@fpellet
Copy link
Contributor

fpellet commented Apr 12, 2024

It's possible to publish a new release (not release) ?
I've been using it in production for several weeks now without any problems.

@64J0
Copy link
Member

64J0 commented Apr 12, 2024

Sure, I'll do that later today

@64J0
Copy link
Member

64J0 commented Apr 13, 2024

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants