From d2b9d02c7a7159bdba7f2265fe95efeca26bc9ab Mon Sep 17 00:00:00 2001 From: Ewen Corre Date: Mon, 20 Jan 2025 14:51:44 +0100 Subject: [PATCH] job_seekers_views: move anonymous_access tests from apply They belong to job_seekers_views now. --- tests/www/apply/test_submit.py | 23 +---------------- .../test_create_or_update.py | 25 +++++++++++++++++++ 2 files changed, 26 insertions(+), 22 deletions(-) diff --git a/tests/www/apply/test_submit.py b/tests/www/apply/test_submit.py index 64227f4e753..d931bd1e662 100644 --- a/tests/www/apply/test_submit.py +++ b/tests/www/apply/test_submit.py @@ -96,21 +96,8 @@ def test_anonymous_access(self, client): "apply:start", "apply:start_hire", "apply:pending_authorization_for_sender", - "job_seekers_views:check_nir_for_sender", - "job_seekers_views:check_nir_for_job_seeker", ): - if viewname.startswith("apply"): - url = reverse(viewname, kwargs={"company_pk": company.pk}) - else: - # Init session (as it would be in apply:start) - session = client.session - session_name = str(uuid.uuid4()) - session[session_name] = { - "config": {}, - "apply": {"company_pk": company.pk}, - } - session.save() - url = reverse(viewname, kwargs={"session_uuid": session_name}) + url = reverse(viewname, kwargs={"company_pk": company.pk}) response = client.get(url) assertRedirects(response, reverse("account_login") + f"?next={url}") @@ -3834,10 +3821,6 @@ def _check_only_administrative_allowed(self, client, user): class TestUpdateJobSeeker(UpdateJobSeekerTestMixin): FINAL_REDIRECT_VIEW_NAME = "apply:application_jobs" - def test_anonymous_start(self, client): - response = client.get(self.start_url) - assertRedirects(response, add_url_params(reverse("account_login"), {"next": self.start_url})) - def test_as_job_seeker(self, client): self._check_nothing_permitted(client, self.job_seeker) @@ -3976,10 +3959,6 @@ def test_as_company_that_last_step_doesnt_crash_with_direct_access(self, client) class TestUpdateJobSeekerForHire(UpdateJobSeekerTestMixin): FINAL_REDIRECT_VIEW_NAME = "job_seekers_views:check_job_seeker_info_for_hire" - def test_anonymous_start(self, client): - response = client.get(self.start_url) - assertRedirects(response, add_url_params(reverse("account_login"), {"next": self.start_url})) - def test_as_job_seeker(self, client): self._check_nothing_permitted(client, self.job_seeker) diff --git a/tests/www/job_seekers_views/test_create_or_update.py b/tests/www/job_seekers_views/test_create_or_update.py index ed9a4a9a719..8b9ebf39b64 100644 --- a/tests/www/job_seekers_views/test_create_or_update.py +++ b/tests/www/job_seekers_views/test_create_or_update.py @@ -2,6 +2,7 @@ import uuid import pytest +from django.template.defaultfilters import urlencode from django.urls import reverse from pytest_django.asserts import assertContains, assertRedirects @@ -52,6 +53,19 @@ def test_itou_staff_are_not_allowed_to_get_or_create_job_seeker(self, client): response = client.get(start_url) assert response.status_code == 403 + def test_anonymous_access(self, client): + company = CompanyFactory() + + for tunnel in self.TUNNELS: + params = { + "tunnel": tunnel, + "company": company.pk, + "from_url": reverse("companies_views:card", kwargs={"siae_id": company.pk}), + } + start_url = add_url_params(reverse("job_seekers_views:get_or_create_start"), params) + response = client.get(start_url) + assertRedirects(response, reverse("account_login") + f"?next={urlencode(start_url)}") + class TestGetOrCreateForJobSeeker: def test_start_create_forbidden_for_job_seekers(self, client): @@ -363,6 +377,17 @@ def test_itou_staff_are_not_allowed_to_update_job_seeker(self, client): response = client.get(start_url) assert response.status_code == 403 + def test_anonymous_access(self, client): + job_seeker = JobSeekerFactory() + + params = { + "job_seeker": job_seeker.public_id, + "from_url": reverse("dashboard:index"), + } + start_url = add_url_params(reverse("job_seekers_views:update_job_seeker_start"), params) + response = client.get(start_url) + assertRedirects(response, reverse("account_login") + f"?next={urlencode(start_url)}") + class TestUpdateForJobSeeker: def test_start_update_job_seeker_forbidden(self, client):