job_seekers_views: manage the session in a mixin and refactor

- ExpectedJobSeekerSessionMixin: to get the session and check that
  it was created to perform the action we're doing
- JobSeekerBaseView: now uses this mixin
- Update views: also use this mixin, instead of inheriting
  JobSeekerBaseView

Author: EwenKorr

itou/www/job_seekers_views/views.py

@@ -225,19 +225,13 @@ def get(self, request, *args, **kwargs):
         return HttpResponseRedirect(reverse(view_name, kwargs={"session_uuid": self.job_seeker_session.name}))
 
 
-class JobSeekerBaseView(TemplateView):
+class ExpectedJobSeekerKindMixin:
     EXPECTED_SESSION_KIND = None
 
     def __init__(self):
-        super().__init__()
-        self.company = None
         self.job_seeker_session = None
-        self.hire_process = None
-        self.prescription_proces = None
-        self.auto_prescription_process = None
-        self.is_gps = False
 
-    def setup(self, request, *args, session_uuid, hire_process=False, **kwargs):
+    def setup(self, request, *args, session_uuid, **kwargs):
         self.job_seeker_session = SessionNamespace(request.session, session_uuid)
         if not self.job_seeker_session.exists():
             raise Http404
@@ -246,6 +240,33 @@ def setup(self, request, *args, session_uuid, hire_process=False, **kwargs):
             session_kind := self.job_seeker_session.get("config").get("session_kind")
         ) and session_kind != self.EXPECTED_SESSION_KIND:
             raise Http404
+
+        super().setup(request, *args, **kwargs)
+
+    def get_reset_url(self):
+        return self.job_seeker_session.get("config", {}).get("from_url") or reverse("dashboard:index")
+
+    def get_back_url(self):
+        return None
+
+    def get_context_data(self, **kwargs):
+        return super().get_context_data(**kwargs) | {
+            "reset_url": self.get_reset_url(),
+            "back_url": self.get_back_url(),
+        }
+
+
+class JobSeekerBaseView(ExpectedJobSeekerKindMixin, TemplateView):
+    def __init__(self):
+        super().__init__()
+        self.company = None
+        self.hire_process = None
+        self.prescription_proces = None
+        self.auto_prescription_process = None
+        self.is_gps = False
+
+    def setup(self, request, *args, hire_process=False, **kwargs):
+        super().setup(request, *args, **kwargs)
         self.is_gps = self.job_seeker_session.get("config", {}).get("tunnel") == "gps"
         if company_pk := self.job_seeker_session.get("apply", {}).get("company_pk"):
             if not self.is_gps:
@@ -266,8 +287,6 @@ def setup(self, request, *args, session_uuid, hire_process=False, **kwargs):
             and self.company == request.current_organization
         )
 
-        super().setup(request, *args, **kwargs)
-
     def redirect_to_check_infos(self, job_seeker_public_id):
         view_name = (
             "job_seekers_views:check_job_seeker_info_for_hire"
@@ -278,17 +297,9 @@ def redirect_to_check_infos(self, job_seeker_public_id):
             reverse(view_name, kwargs={"company_pk": self.company.pk, "job_seeker_public_id": job_seeker_public_id})
         )
 
-    def get_back_url(self):
-        return None
-
-    def get_reset_url(self):
-        return self.job_seeker_session.get("config", {}).get("from_url") or reverse("dashboard:index")
-
     def get_context_data(self, **kwargs):
         return super().get_context_data(**kwargs) | {
             "siae": self.company,
-            "back_url": self.get_back_url(),
-            "reset_url": self.get_reset_url(),
             "hire_process": self.hire_process,
             "prescription_process": self.prescription_process,
             "auto_prescription_process": self.auto_prescription_process,
@@ -832,7 +843,7 @@ def get(self, request, *args, **kwargs):
         )
 
 
-class UpdateJobSeekerBaseView(JobSeekerBaseView):
+class UpdateJobSeekerBaseView(ExpectedJobSeekerKindMixin, TemplateView):
     EXPECTED_SESSION_KIND = JobSeekerSessionKinds.UPDATE
 
     def __init__(self):