Email reconfirmation

[edbond]

When user changes email in profile, reconfirmation email should be sent.
Devise does have reconfirmation feature.

[atd]

A patch is welcomed!

[edbond]

Here is a quick summary of my monkey-patching:

add email column to User and copy email from Actor (note that unconfirmed_email is already in users):

class AddEmailToUsers < ActiveRecord::Migration
  def up
    add_column :users, :email, :string

    User.reset_column_information

    User.all(include: :actor).each do |u|
      u.email = u.actor.email
      u.unconfirmed_email = nil
      u.skip_confirmation!
      u.skip_reconfirmation!
      u.save!
    end
  end

  def down
    # Copy email to actor
    User.all(include: :actor).each do |u|
      u.actor.update_attributes! email: u.email
    end

    remove_column :users, :email
  end
end

wire profle and user, add to Profile model:

  has_one :user, through: :actor
  accepts_nested_attributes_for :user

change field_for in profile/edit to use user:

  <%= f.fields_for :user do |user_form| %>
      <%= custom_field user_form, :email, label: t('profile.email') %>
  <% end %>

HTH

[atd]

Hi @edbond, I cannot see how unconfirmed emails are confirmed again.

Anyway, I believe the right place to make this contribution is Devise itself, don't you think so?

[edbond]

Devise already have such feature, see http://rubydoc.info/github/plataformatec/devise/master/Devise/Models/Confirmable

• +reconfirmable+: requires any email changes to be confirmed (exactly the same way as
  initial account confirmation) to be applied. Requires additional unconfirmed_email
  db field to be setup (t.reconfirmable in migrations). Until confirmed new email is
  stored in unconfirmed email column, and copied to email column on successful
  confirmation.

social_stream breaks it.

[atd]

Sorry @edbond, I did not notice.

Why replicating the column from actors.email to the users table?

[edbond]

This was needed for email_changed and devise callbacks work. Maybe it can be achieved without replication.

[atd]

It works for me...

atd@seraph:~/dev/social_stream/spec/dummy$ rails c
Loading development environment (Rails 3.2.11)
[1] pry(main)> u = User.first
  User Load (0.2ms)  SELECT "users".* FROM "users" LIMIT 1
  Actor Load (0.6ms)  SELECT "actors".* FROM "actors" WHERE "actors"."id" = 1 LIMIT 1
  ActivityObject Load (0.2ms)  SELECT "activity_objects".* FROM "activity_objects" WHERE "activity_objects"."id" = 1 LIMIT 1
=> #<User id: 1, encrypted_password: "$2a$10$UKK1LcHAoYwf2HVCeXCa3Og2AnbRjaFIZgzTaNrJWc8V...", password_salt: nil, reset_password_token: nil, reset_password_sent_at: nil, remember_created_at: nil, sign_in_count: 0, current_sign_in_at: nil, last_sign_in_at: nil, current_sign_in_ip: nil, last_sign_in_ip: nil, authentication_token: nil, created_at: "2013-01-25 15:01:21", updated_at: "2013-01-25 15:01:21", actor_id: 1, language: nil, connected: false, status: "available", chat_enabled: true>
[2] pry(main)> u.email_changed?
=> false
[3] pry(main)> u.email = "[email protected]"
=> "[email protected]"
[4] pry(main)> u.email_changed?
=> true
[5] pry(main)>

[edbond]

afaik this call was forwarded to Actor which is not devise model. Try to change email and save, you will not get reconfirmation email.

[atd]

Please, provide an application or spec that reproduces it

[edbond]

Here is a spec which pass after changes:

describe User do
  let(:old_email) { "[email protected]" }
  let(:new_email) { "[email protected]" }

  let(:password) { "Udur9uYo" }

  it "asks to confirm changed email" do
    user = FactoryGirl.build(:user, email: old_email, password: password,
      password_confirmation: password)
    user.skip_confirmation!
    user.save!

    user.valid_password?(password).should be_true

    ActionMailer::Base.deliveries.clear
    user.reload

    user.email = new_email
    user.save!

    ActionMailer::Base.deliveries.should_not be_empty
  end
end

[atd]

The spec does not work in current Social Stream's code:

  1) User asks to confirm changed email
     Failure/Error: user = FactoryGirl.build(:user, email: old_email, password: password,
     NameError:
       uninitialized constant FactoryGirl
     # ./base/spec/models/user_email_spec.rb:10:in `block (2 levels) in <top (required)>'

Finished in 0.00169 seconds
1 example, 1 failure

[edbond]

Nevermind, if someone needs to fix confirmation it will find the code here.

[atd]

It seems that the User model is not changed and thus is not updated, so Devise's callback is not triggered.

[edbond]

Yes, maybe you can forward email_changed from Actor to User?