backup triggers keychain popup for password despite env password

[robbat2]

If a password is provided via environment, Duplicacy should NOT contact the keyring service.

Doing the following causes a keyring password prompt to pop up, but the command continues & completes even while the keyring popup is on the screen.

export DUPLICACY_PASSWORD=foobar123
duplicacy init -e  snapshot-id /tmp/storage-dir/
duplicacy backup

Doing strace on the backup shows it contacting DBus for the secret service.

[pid  3986] connect(4, {sa_family=AF_UNIX, sun_path=@"/tmp/dbus-enuP1HYy8w"}, 23) = 0
[pid  3986] getpeername(4, {sa_family=AF_UNIX, sun_path=@"/tmp/dbus-enuP1HYy8w"}, [112->23]) = 0
[pid  3986] <... read resumed> "REJECTED EXTERNAL DBUS_COOKIE_SHA1 ANONYMOUS\r\n", 4096) = 46
...
[pid  3989] write(4, "l\1\0\1\25\0\0\0\2\0\0\0\220\0\0\0\1\1o\0\30\0\0\0/org/freedesktop/secrets\0\0\0\0\0\0\0\0\6\1s\0\27\0\0\0org.freedesktop.secrets\0\3\1s\0\v\0\0\0OpenSession\0\0\0\0\0\2\1s\0\36\0\0\0org.freedesktop.Secret.Service\0\0\10\1g\0\2sv\0\5\0\0\0plain\0\1s\0\0\0\0\0\0\0\0\0", 181 <unfinished ...>

[gilbertchen]

Good point. It really shouldn't.

[gilbertchen]

Fixed by 3f83890

[tbain98]

If this issue was fixed via that commit, shouldn't it be transitioned to a Closed state?

[gilbertchen]

Usually I want the fix to be comfirmed first before I close it.

[tbain98]

Makes sense. I've not developed on GitHub, and I'm used to issue tracking workflows where there's a state that means "implemented but not yet confirmed to work," so I was assuming there was such a state available; sorry for the confusion.

[robbat2]

I want to test this, but duplicacy is not building presently, so
I have to wait for the next release. #56 (comment)

[gilbertchen]

@robbat2 I don't know what went wrong there but can you try go get -u ./... instead?

[robbat2]

I got it built now (commit 8808ad5), and I'm still being prompted for keychain.

[gilbertchen]

Can anyone else confirm whether the fix is working or now?