Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batch_sentences() got an unexpected keyword argument 'max_length' #4

Open
thomas-davis opened this issue Oct 24, 2019 · 5 comments
Open

Comments

@thomas-davis
Copy link

Bilm Batcher.batch_sentences (here: https://github.com/allenai/bilm-tf/blob/master/bilm/data.py) doesn't accept a max_length argument. I can't find a version in their github history that does. Any work around? Can I safely remove the max_length argument.
Thanks!

@haoyangz
Copy link
Contributor

Have you run python update_blim.py as mentioned in the README?

@thomas-davis
Copy link
Author

woops, thank you, resolved.

@thomas-davis
Copy link
Author

Also can I ask, how would one convert column 1 and 2 of the prediction output into nanomolar affinities (as I think is done in fig 4 of your Bioinformatics paper). Is this conversion possible?
Thanks again.

@haoyangz
Copy link
Contributor

@thomas-davis conversion between nanomolar and the normalized scaled is described in the second paragraph in section 2.1 of the paper. For fig 4, I believe the affinity mean prediction (first column of the output) was used to convert to nanomolar.

@thomas-davis
Copy link
Author

Thank you again! one last question-- I'd like to run the affinity only or embedding only model for a dataset, and wasn't sure how to go about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants