Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistent data names for km and make.surv #52

Open
n8thangreen opened this issue Nov 9, 2022 · 3 comments
Open

consistent data names for km and make.surv #52

n8thangreen opened this issue Nov 9, 2022 · 3 comments

Comments

@n8thangreen
Copy link
Contributor

n8thangreen commented Nov 9, 2022

km in fit.model output names time, mean, upper and lower 95% CI as

time, surv, lower, upper

make.surv output names these as

t, S, low, upp.

This makes applying a common function to both of these more difficult.

@giabaio
Copy link
Owner

giabaio commented Nov 10, 2022

Thanks. That's actually a good point. I suspect that I may have messed up slightly though and that the naming is propagated throughout the other utility functions (mainly plotting...). Have you checked this? It's probably a matter of grep to check when we're calling what? Or have you changed in your version and can push the changes to the main repo?

Thanks!

@n8thangreen
Copy link
Contributor Author

I don't think these fields from make.surv are used very much internally. All I can find is one in psa.plot(). I can have a go at changing them - and try some tests?

@giabaio
Copy link
Owner

giabaio commented Nov 10, 2022

Ha --- even better then... That'd be cool if you are playing with it anyway?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants