[🐞] MethodError: no method matching DIVAnd.VertRandomCoupels(::Float32, ...

[ctroupin]

Describe the bug

• The test test_fit.jl leads to an error, different from what is reported in DIVAnd test failed during Pkg.test("DVAnd")[🐞] #142
• Linked to commit 589457e ?
• Typo (not issue): VertRandomCoupels → VertRandomCouples

Environment

• Julia version: 1.10.4
• Operating system: Ubuntu 22.04.3 LTS

Installed modules

(@v1.10) pkg> st
Status `~/.julia/environments/v1.10/Project.toml`
  [052768ef] CUDA v5.4.2
  [8f4d0f93] Conda v1.10.0
  [0d879ee6] DINCAE v2.0.4
  [efc8151c] DIVAnd v2.7.11
  [864edb3b] DataStructures v0.18.20
  [8bb1440f] DelimitedFiles v1.9.1
  [587475ba] Flux v0.14.15
⌃ [2fb1d81b] GeoArrays v0.8.5
  [61d90e0f] GeoJSON v0.8.1
  [bb4c363b] GridInterpolations v1.1.3
  [7073ff75] IJulia v1.24.2
  [6a3955dd] ImageFiltering v0.7.8
  [a98d9a8b] Interpolations v0.15.1
  [682c06a0] JSON v0.21.4
  [98e50ef6] JuliaFormatter v1.0.56
  [85f8d34a] NCDatasets v0.14.4
  [d330b81b] PyPlot v2.11.2
  [860ef19b] StableRNGs v1.0.2
  [02a925ec] cuDNN v1.3.2

To Reproduce

julia test_fit.jl

Full screen output

Error During Test at /home/dincae/DIVAnd.jl/test/test_fit.jl:174
  Test threw exception
  Expression: DIVAnd.fitvertlen(map((v->begin
                T.(v)
            end), x), v, T.(z); epsilon2 = T.(epsilon2), rng = rng)
  MethodError: no method matching DIVAnd.VertRandomCoupels(::Float32, ::Vector{Int64}, ::Tuple{Vector{Float32}, Vector{Float32}, Vector{Float32}}, ::Float64, ::Int64, ::Int64, ::StableRNGs.LehmerRNG)
  
  Closest candidates are:
    DIVAnd.VertRandomCoupels(::Float64, ::Vector{Int64}, ::Tuple{Vector{Float64}, Vector{Float64}, Vector{Float64}}, ::Float64, ::Int64, ::Int64, ::TRNG) where TRNG<:AbstractRNG
     @ DIVAnd ~/.julia/packages/DIVAnd/EG6qD/src/fit.jl:315
  
  Stacktrace:
    [1] fitvertlen(x::Tuple{Vector{Float32}, Vector{Float32}, Vector{Float32}}, value::Vector{Float64}, z::Vector{Float32}; smoothz::Float64, smoothk::Float64, searchz::Float64, searchxy::Float64, maxntries::Int64, maxnsamp::Int64, progress::Function, distfun::Function, limitfun::DIVAnd.var"#582#589", epsilon2::Vector{Float32}, min_rqual::Float64, rng::StableRNGs.LehmerRNG)
      @ DIVAnd ~/.julia/packages/DIVAnd/EG6qD/src/fit.jl:923
    [2] (::var"#5#7")()
      @ Main ./none:0
    [3] with_logstate(f::Function, logstate::Any)
      @ Base.CoreLogging ./logging.jl:515
    [4] with_logger
      @ ./logging.jl:627 [inlined]
    [5] #collect_test_logs#73
      @ ~/.julia/juliaup/julia-1.10.2+0.x64.linux.gnu/share/julia/stdlib/v1.10/Test/src/logging.jl:114 [inlined]
    [6] collect_test_logs
      @ ~/.julia/juliaup/julia-1.10.2+0.x64.linux.gnu/share/julia/stdlib/v1.10/Test/src/logging.jl:112 [inlined]
    [7] #match_logs#74
      @ ~/.julia/juliaup/julia-1.10.2+0.x64.linux.gnu/share/julia/stdlib/v1.10/Test/src/logging.jl:260 [inlined]
    [8] top-level scope
      @ ~/DIVAnd.jl/test/test_fit.jl:173
    [9] include(mod::Module, _path::String)
      @ Base ./Base.jl:495
   [10] exec_options(opts::Base.JLOptions)
      @ Base ./client.jl:318
   [11] _start()
      @ Base ./client.jl:552
ERROR: LoadError: There was an error during testing
in expression starting at /home/dincae/DIVAnd.jl/test/test_fit.jl:173

[Alexander-Barth]

I don't see the error myself with current commit: 8b4ddc1

julia> include("/home/abarth/.julia/dev/DIVAnd/test/test_fit.jl");
# no output

Current CI seem ok https://github.com/gher-uliege/DIVAnd.jl/actions/runs/9413048562

[Alexander-Barth]

@ctroupin feel free to make a new release if the fix is in the master version, but you need a released version.

See point 3 of the list here https://github.com/JuliaRegistries/Registrator.jl?tab=readme-ov-file#via-the-github-app

[ctroupin]

OK thanks, I don't know why I got it with 589457e
but anyway let's close the issue.

[Alexander-Barth]

As you have [efc8151c] DIVAnd v2.7.11 in your environment, you maybe used the previously released version and not the git version. I would install DIVAnd with dev DIVAnd and use git to keep your copy up to date.