Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer skews image by Y axis due to constant height of 100px #41

Open
lid3rs opened this issue Dec 1, 2020 · 0 comments
Open

Footer skews image by Y axis due to constant height of 100px #41

lid3rs opened this issue Dec 1, 2020 · 0 comments

Comments

@lid3rs
Copy link

lid3rs commented Dec 1, 2020

"react-native-amazing-cropper": "^0.1.4",
"react-native": "0.63.3",

Thank you for your work, really good app!

If i have custom footer with different height than 100 - it causes problems to center align image. Second: image is skewed by Y axis due to this. i would highly recommend to review the markup and make it more independent of constants and absolute positioning. I would made accent towards flexbox.

footerContainer: {
            position: 'absolute',
            top: COMPONENT_HEIGHT - Q, // <<<<<
            height: Q,
            width: W,
        },
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant