Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmaintained Dependency - react-native-image-rotate #24

Open
ahmed-ismail-nt opened this issue Mar 21, 2020 · 6 comments
Open

Unmaintained Dependency - react-native-image-rotate #24

ahmed-ismail-nt opened this issue Mar 21, 2020 · 6 comments

Comments

@ahmed-ismail-nt
Copy link

Thank you for this package. It's a good package, I like it more than the alternatives and it has a lot of promise.

Issue
The react-native-image-rotate package is no longer being maintained.

At first glance, these are some issues already cropping up:

  1. iOS-specific: The package uses deprecated methods from RCTImageStoreManager.h in RNImageRotate/ImageRotateModule.m. The imports need to be updated as well.
  2. Android-specific: The android/build.gradle file needs to be updated.

How will you be handling this in future releases?

@ggunti
Copy link
Owner

ggunti commented Mar 22, 2020

Can you recommend a similar maintained library that we could use instead react-native-image-rotate?
We could use ImageManipulator, but I think that it will enforce to use expo and I don't like the idea (in bare react native projects can be used only if we install also the react-native-unimodules package, which is +1 dependency, which is not desired).
An another alternative could be to remove the rotation feature from this package.

@NateC3
Copy link

NateC3 commented Apr 10, 2020

Maybe you could remove the rotation feature for the time being until an alternative is found? That way we can continue using this.

@sergiulucaci
Copy link

I would suggest to remove the rotation feature too.

@bitlab-code
Copy link

currently expo ship with a bare workflow, alternatively app bootstrapped with react-native cli can easy install unimodules so (imho) use the expo ImageManipulator it's a good idea

or you can think to fork and edit ImageManipulator just like this test

@kidculli
Copy link

Can you recommend a similar maintained library that we could use instead react-native-image-rotate? We could use ImageManipulator, but I think that it will enforce to use expo and I don't like the idea (in bare react native projects can be used only if we install also the react-native-unimodules package, which is +1 dependency, which is not desired). An another alternative could be to remove the rotation feature from this package.

https://github.com/pontusab/react-native-image-manipulator

This package seems to be maintained and has a rotate method

@ggunti ggunti closed this as completed Sep 15, 2022
@ggunti
Copy link
Owner

ggunti commented Sep 19, 2022

@kidculli Tried it and it does not seem to work properly.

@ggunti ggunti reopened this Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants