Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gerrithook doesn't appear to work when run from a subdirectory #105

Closed
zombiezen opened this issue Apr 18, 2019 · 1 comment
Closed

gerrithook doesn't appear to work when run from a subdirectory #105

zombiezen opened this issue Apr 18, 2019 · 1 comment
Labels
bug Something isn't working
Milestone
1.0

Comments

@zombiezen
Copy link
Member

gerrithook doesn't appear to work when run from a subdirectory. Repro case is straightforward and I'm fairly certain of it.
@zombiezen zombiezen added the bug Something isn't working label Apr 18, 2019
@zombiezen zombiezen added this to the 0.8 milestone Apr 18, 2019
@zombiezen
Copy link
Member Author

This appears to be an issue with older versions of Git: the regression test I've developed for this fails on Git 2.12.5, but not 2.13.7. It appears as though git rev-parse --git-common-dir returns incorrect results. When in a subdirectory foo, Git 2.13.7 yields ../.git whereas Git 2.12.5 yields foo/.git (which is all flavors of wrong).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
1.0
Development

No branches or pull requests
1 participant
@zombiezen