Skip to content

pre-ll: Vertex & constant structs fields are re-ordered in rust 1.67 so don't work #3790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexheretic opened this issue Jan 26, 2023 · 1 comment
Labels
api: pre-ll old abstraction layer (pre-ll branch) type: bug value: high

Comments

@alexheretic
Copy link
Contributor

GFX version: v0.18

Previously working code stops working properly with rust 1.67 (though still compiles).

gfx_defines! {
    vertex Vertex {
        ...
    }
    constant Props {
        ...
    }
    ...
}

This can be manually fixed by declaring #[repr(C)]

gfx_defines! {
    #[repr(C)]
    vertex Vertex {
        ...
    }
    #[repr(C)]
    constant Props {
        ...
    }
    ...
}

I think it would be nice to release a new version that will fix this without such intervention.

@alexheretic
Copy link
Contributor Author

Resolved by #3791 #3792

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pre-ll old abstraction layer (pre-ll branch) type: bug value: high
Projects
None yet
Development

No branches or pull requests

2 participants