Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flickering on Metal with Immediate presentation mode #2165

Closed
kvark opened this issue Jun 21, 2018 · 1 comment
Closed

Flickering on Metal with Immediate presentation mode #2165

kvark opened this issue Jun 21, 2018 · 1 comment

Comments

@kvark
Copy link
Member

kvark commented Jun 21, 2018

Dota shows visible artifacts in refreshed frames, but only when running with v-sync OFF.

I suspect the problem coming from this piece:

msg_send![drawable, present];
msg_send![drawable, release];

When running with v-sync, present() blocks until the vertical ray, then displays the contents, and then returns. So we are free to release the drawable right after.
When running without v-sync, the present() returns immediately, but there is still going to be some time before the image appears on screen. We need to hold it for the mean time and not release.

@kvark
Copy link
Member Author

kvark commented Jun 26, 2018

Fixed by #2169

@kvark kvark closed this as completed Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant