Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up jhipster code (sonarqube) #19

Open
geyuqiu opened this issue Jul 4, 2020 · 1 comment
Open

clean up jhipster code (sonarqube) #19

geyuqiu opened this issue Jul 4, 2020 · 1 comment
Labels
QA QA and unit-, i-, ui-, tests

Comments

@geyuqiu
Copy link
Owner

geyuqiu commented Jul 4, 2020

No description provided.

@geyuqiu
Copy link
Owner Author

geyuqiu commented Jul 4, 2020 •
edited
Loading

  • remove code smells via
    • lombok
    • removing unsed services: e.g. mailService
    • cleaning up pom.xml
    • cleaning up application.yml
    • removing public for test methods in *.java

geyuqiu pushed a commit that referenced this issue Jul 4, 2020
#19.: clean up getter, setter, toString, remove activated in user, de…
e865d93 
…lete mailService
geyuqiu pushed a commit that referenced this issue Jul 4, 2020
#19.: clean up pom and yml
e8ea251
geyuqiu pushed a commit that referenced this issue Jul 4, 2020
#19.: remove empty source file and public keyword in test files
63c9bec
geyuqiu pushed a commit that referenced this issue Jul 4, 2020
#19.: remove activated from liquibase files
3896af9
geyuqiu pushed a commit that referenced this issue Jul 4, 2020
#19.: revert bad clean
0e8c788
geyuqiu pushed a commit that referenced this issue Jul 5, 2020
#19.: clean up hashcode and equals methods in POJO
1903b4a
geyuqiu pushed a commit that referenced this issue Jul 5, 2020
#28.: add server side filter for transaction, #19.: remove hashcode c…
d7e9e14 
…heck in tests
@geyuqiu geyuqiu added enhancement New feature or request QA QA and unit-, i-, ui-, tests and removed enhancement New feature or request labels Jul 5, 2020
geyuqiu pushed a commit that referenced this issue Jul 5, 2020
#19.: resolve code smells, errors indicated on sonar
d4b12e3
geyuqiu pushed a commit that referenced this issue Jul 5, 2020
#19.: clean up sonar code smells
dd25d81
geyuqiu pushed a commit that referenced this issue Jul 6, 2020
#19.: clean up user-, Resource, services
b4a2df8
geyuqiu pushed a commit that referenced this issue Jul 6, 2020
#6.: progress indicator and clean up #19, closes 36
aee7016
geyuqiu pushed a commit that referenced this issue Jul 6, 2020
#6.: progress indicator and clean up #19, closes #36
3c99db6
geyuqiu pushed a commit that referenced this issue Jul 9, 2020
#19.: fix weird static code analyzer
6b84410
geyuqiu pushed a commit that referenced this issue Jul 9, 2020
#19.: clean up unused docker files
82bdd28
geyuqiu pushed a commit that referenced this issue Jul 9, 2020
Merge pull request #42 from geyuqiu/feature/split-code
c5f9ac4 
#19.: clean up unused docker files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
QA QA and unit-, i-, ui-, tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@geyuqiu