diff --git a/snuba/web/rpc/v1/endpoint_get_traces.py b/snuba/web/rpc/v1/endpoint_get_traces.py index fbb373529d1..572ede9fc91 100644 --- a/snuba/web/rpc/v1/endpoint_get_traces.py +++ b/snuba/web/rpc/v1/endpoint_get_traces.py @@ -218,7 +218,7 @@ def _select_supported_filters( return next( f.filter for f in filters - if f.item_name == TraceItemType.TRACE_ITEM_TYPE_SPAN + if f.item_type == TraceItemType.TRACE_ITEM_TYPE_SPAN ) except StopIteration: raise BadSnubaRPCRequestException("Only one span filter is supported.") diff --git a/snuba/web/rpc/v1/endpoint_trace_item_table.py b/snuba/web/rpc/v1/endpoint_trace_item_table.py index 34c64ebcf64..c22355193c5 100644 --- a/snuba/web/rpc/v1/endpoint_trace_item_table.py +++ b/snuba/web/rpc/v1/endpoint_trace_item_table.py @@ -103,5 +103,5 @@ def _execute(self, in_msg: TraceItemTableRequest) -> TraceItemTableResponse: # for backwards compatibility if in_msg.meta.trace_item_type == TraceItemType.TRACE_ITEM_TYPE_UNSPECIFIED: in_msg.meta.trace_item_type = TraceItemType.TRACE_ITEM_TYPE_SPAN - resolver = self.get_resolver(in_msg.meta.trace_item_name) + resolver = self.get_resolver(in_msg.meta.trace_item_type) return resolver.resolve(in_msg) diff --git a/tests/web/rpc/v1/test_endpoint_get_traces.py b/tests/web/rpc/v1/test_endpoint_get_traces.py index 3e0726cd700..ed1d7331860 100644 --- a/tests/web/rpc/v1/test_endpoint_get_traces.py +++ b/tests/web/rpc/v1/test_endpoint_get_traces.py @@ -295,7 +295,7 @@ def test_with_data_and_filter(self, setup_teardown: Any) -> None: ), filters=[ GetTracesRequest.TraceFilter( - item_name=TraceItemType.TRACE_ITEM_TYPE_SPAN, + item_type=TraceItemType.TRACE_ITEM_TYPE_SPAN, filter=TraceItemFilter( comparison_filter=ComparisonFilter( key=AttributeKey( @@ -383,7 +383,7 @@ def test_with_data_and_aggregated_fields(self, setup_teardown: Any) -> None: ], filters=[ GetTracesRequest.TraceFilter( - item_name=TraceItemType.TRACE_ITEM_TYPE_SPAN, + item_type=TraceItemType.TRACE_ITEM_TYPE_SPAN, filter=TraceItemFilter( comparison_filter=ComparisonFilter( key=AttributeKey(