Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SearchQueryBuilder] Support special character escapement for search bar filter keys #84536

Open
aliu39 opened this issue Feb 4, 2025 · 1 comment

Comments

@aliu39
Copy link
Member

aliu39 commented Feb 4, 2025

Follow-up on thread here: #83968 (comment)
Arose from a PR for feature flags search, where : characters in the flag key conflicted with our search syntax (e.g. key=val is submitted to API as key:val, key>val is key:>val)

@malwilley:

What I meant was, we already have logic that will "escape" filter values by wrapping them in quotes when they contain things like spaces, quotes, parens, etc. We could do something similar with filter keys where we wrap them when necessary, which would mean that you wouldn't have to wrap them in quotes in the config up front

@getsantry
Copy link
Contributor

getsantry bot commented Feb 4, 2025

Routing to @getsentry/product-owners-issues for triage ⏲️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

1 participant