Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organization invite is broken for accounts with 2FA #84510

Open
shellmayr opened this issue Feb 4, 2025 · 3 comments
Open

Organization invite is broken for accounts with 2FA #84510

shellmayr opened this issue Feb 4, 2025 · 3 comments

Comments

@shellmayr
Copy link
Member

Environment

SaaS (https://sentry.io/)

Steps to Reproduce

  1. Create user-1 with a new org org-1
  2. Setup 2FA for the user-1
  3. Logout
  4. Create user-2 with new org org-2
  5. Invite user-1 to join org-2
  6. Logout
  7. Click invite link and try to login to user-1

Expected Result

Being able to accept an organization invite and logging me in

Actual Result

Infinite loop of Login Form -> Join Org Dialog -> Login Form -> etc.

Product Area

Unknown

Link

https://{ORG_ID}.sentry.io/accept/{INDIVIDUAL_LINK}

DSN

No response

Version

No response

@getsantry
Copy link
Contributor

getsantry bot commented Feb 4, 2025

Routing to @getsentry/product-owners-settings-auth for triage ⏲️

@leedongwei
Copy link
Member

Seems replicated by #84292. We have someone investigating.

@mifu67
Copy link
Contributor

mifu67 commented Feb 4, 2025

I believe this is happening because the org member invite endpoint initiates login and sets a next_url if the user is not authenticated—this means that if a user has set up 2FA, then they will not continue to the 2FA view and instead be redirected back to the invite acceptance view, thus never being able to complete their authentication flow.

We're planning to rework the organization invite acceptance flow as part of the Auth V2 project. A workaround for now should be to first log in as User 1 before accepting the organization invite to Org 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

3 participants