Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replay playback can lose fidelity (extra spacings, etc) #57820

Closed
bruno-garcia opened this issue Oct 10, 2023 · 1 comment
Closed

Replay playback can lose fidelity (extra spacings, etc) #57820

bruno-garcia opened this issue Oct 10, 2023 · 1 comment
Assignees
@billyvg

Comments

@bruno-garcia
Copy link
Member

bruno-garcia commented Oct 10, 2023 •
edited by billyvg
Loading

Example replay: https://sentry.sentry.io/replays/1bf88d854ff34f09a9d0a23ccafbff33/

Playing from the start without scrubbing back/forward works fine. Only when clicking back in time it renders differently:

image

Normal playback assigns the correct dimensions to svg, but it looks like the replayer is losing the svg dimensions when we scrub forward/backwards.

Closes https://github.com/getsentry/team-replay/issues/233
@billyvg billyvg self-assigned this Oct 16, 2023
@billyvg
Copy link
Member

billyvg commented Oct 20, 2023

This will be fixed when we publish this fix

@bruno-garcia bruno-garcia mentioned this issue Oct 23, 2023
Merged
billyvg pushed a commit that referenced this issue Oct 23, 2023
@bruno-garcia
chore(replay): rrweb player 2.1.1 (#58594)
da1d389 
this bump includes a fix to:
#57820
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@billyvg billyvg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@billyvg @bruno-garcia