Merge branch 'master' into ref/em-simplify-signals

* master: (57 commits)
  ref(getting-started): Change code to always update loader script when products changes (#86583)
  ref(spans): Detect performance issues directly in segments consumer (#86595)
  ref(getting-started): Update copies, replacing 'Sentry dashboard' with 'Sentry Issues' (#86672)
  ref(product-selection): Update code to not strip url (#86582)
  ref(quick-start): Replace 'record' with 'create_or_update' in 'record_new_project' (#86663)
  ref(assemble): Remove old `find_missing_chunks` method (#86588)
  fix(views):Exclude newly added views from last visited update as well (#86653)
  feat(workflow_engine): Only execute enabled Detectors (#86652)
  fix(autofix): Github links, remove seer branding, and UI cleanup (#86640)
  fix(seer-issues-patch) More parsing of functions for Python (#86558)
  ref(ui): Remove sentry.eot (#86649)
  feat(alerts): Restrict uptime/crons overview buttons for alerts:write (#86436)
  chore(deps): bump axios from 1.7.7 to 1.8.2 (#86642)
  deps(ui): Upgrade prettier (#86634)
  deps(ui): Upgrade eslint, biome (#86630)
  fix(shared-views): Fix default view passing to last visited endpoint (#86632)
  feat(billing): update copy for payg disabled CTA (#86143)
  ref(ui): Remove usage of withOrganization from organizationAuthList (#86554)
  fix(crons): Fix disabled state of disable button (#86637)
  feat(ui): Replace OrganizationAuth DeprecatedAsyncComponent (#86556)
  ...

Author: jan-auer

eslint.config.mjs

@@ -11,13 +11,13 @@
  */
 import * as emotion from '@emotion/eslint-plugin';
 import eslint from '@eslint/js';
+import {globalIgnores} from 'eslint/config';
 import prettier from 'eslint-config-prettier';
 // @ts-expect-error TS(7016): Could not find a declaration file
 import importPlugin from 'eslint-plugin-import';
 import jest from 'eslint-plugin-jest';
 import jestDom from 'eslint-plugin-jest-dom';
 import react from 'eslint-plugin-react';
-// @ts-expect-error TS(7016): Could not find a declaration file
 import reactHooks from 'eslint-plugin-react-hooks';
 // @ts-expect-error TS(7016): Could not find a declaration file
 import sentry from 'eslint-plugin-sentry';
@@ -174,34 +174,31 @@ export default typescript.config([
     // https://eslint.org/docs/latest/use/configure/configuration-files#specifying-files-and-ignores
     files: ['**/*.js', '**/*.mjs', '**/*.ts', '**/*.jsx', '**/*.tsx'],
   },
-  {
-    name: 'eslint/global/ignores',
-    // Global ignores
-    // https://eslint.org/docs/latest/use/configure/configuration-files#globally-ignoring-files-with-ignores
-    ignores: [
-      '.devenv/**/*',
-      '.github/**/*',
-      '.mypy_cache/**/*',
-      '.pytest_cache/**/*',
-      '.venv/**/*',
-      '**/*.benchmark.ts',
-      '**/*.d.ts',
-      '**/dist/**/*',
-      '**/tests/**/fixtures/**/*',
-      '**/vendor/**/*',
-      'build-utils/**/*',
-      'config/chartcuterie/config.js', // TODO: see if this file exists
-      'fixtures/artifact_bundle/**/*',
-      'fixtures/artifact_bundle_debug_ids/**/*',
-      'fixtures/artifact_bundle_duplicated_debug_ids/**/*',
-      'fixtures/profiles/embedded.js',
-      'jest.config.ts',
-      'api-docs/**/*',
-      'src/sentry/static/sentry/js/**/*',
-      'src/sentry/templates/sentry/**/*',
-      'stylelint.config.js',
-    ],
-  },
+  // Global ignores
+  // https://eslint.org/docs/latest/use/configure/configuration-files#globally-ignoring-files-with-ignores
+  globalIgnores([
+    '.devenv/**/*',
+    '.github/**/*',
+    '.mypy_cache/**/*',
+    '.pytest_cache/**/*',
+    '.venv/**/*',
+    '**/*.benchmark.ts',
+    '**/*.d.ts',
+    '**/dist/**/*',
+    '**/tests/**/fixtures/**/*',
+    '**/vendor/**/*',
+    'build-utils/**/*',
+    'config/chartcuterie/config.js',
+    'fixtures/artifact_bundle/**/*',
+    'fixtures/artifact_bundle_debug_ids/**/*',
+    'fixtures/artifact_bundle_duplicated_debug_ids/**/*',
+    'fixtures/profiles/embedded.js',
+    'jest.config.ts',
+    'api-docs/**/*',
+    'src/sentry/static/sentry/js/**/*',
+    'src/sentry/templates/sentry/**/*',
+    'stylelint.config.js',
+  ]),
   /**
    * Rules are grouped by plugin. If you want to override a specific rule inside
    * the recommended set, then it's recommended to spread the new rule on top

package.json

@@ -140,7 +140,7 @@
     "peggy": "^4.1.1",
     "platformicons": "^8.0.0",
     "po-catalog-loader": "2.1.0",
-    "prettier": "3.3.2",
+    "prettier": "3.5.3",
     "prismjs": "^1.29.0",
     "process": "^0.11.10",
     "qrcode.react": "^3.1.0",
@@ -175,12 +175,12 @@
     "zxcvbn": "^4.4.2"
   },
   "devDependencies": {
-    "@biomejs/biome": "^1.9.1",
+    "@biomejs/biome": "^1.9.4",
     "@codecov/webpack-plugin": "^1.8.0",
     "@emotion/eslint-plugin": "^11.12.0",
-    "@eslint/compat": "^1.2.4",
-    "@eslint/eslintrc": "^3.2.0",
-    "@eslint/js": "^9.17.0",
+    "@eslint/compat": "^1.2.7",
+    "@eslint/eslintrc": "^3.3.0",
+    "@eslint/js": "^9.22.0",
     "@pmmmwh/react-refresh-webpack-plugin": "0.5.15",
     "@sentry/jest-environment": "6.0.0",
     "@sentry/profiling-node": "9.6.0-alpha.0",
@@ -194,19 +194,19 @@
     "babel-gettext-extractor": "^4.1.3",
     "babel-jest": "29.7.0",
     "benchmark": "^2.1.4",
-    "eslint": "^9.17.0",
-    "eslint-config-prettier": "^9.1.0",
-    "eslint-import-resolver-typescript": "^3.7.0",
+    "eslint": "^9.22.0",
+    "eslint-config-prettier": "^10.1.1",
+    "eslint-import-resolver-typescript": "^3.8.3",
     "eslint-plugin-import": "^2.31.0",
-    "eslint-plugin-jest": "^28.10.0",
+    "eslint-plugin-jest": "^28.11.0",
     "eslint-plugin-jest-dom": "^5.5.0",
-    "eslint-plugin-react": "^7.37.3",
-    "eslint-plugin-react-hooks": "5.0.0",
+    "eslint-plugin-react": "^7.37.4",
+    "eslint-plugin-react-hooks": "5.2.0",
     "eslint-plugin-sentry": "^2.10.0",
     "eslint-plugin-simple-import-sort": "^12.1.1",
     "eslint-plugin-testing-library": "^7.1.1",
     "eslint-plugin-typescript-sort-keys": "^3.3.0",
-    "eslint-plugin-unicorn": "^56.0.1",
+    "eslint-plugin-unicorn": "^57.0.0",
     "globals": "^15.14.0",
     "html-webpack-plugin": "^5.6.0",
     "jest": "29.7.0",
@@ -220,7 +220,7 @@
     "stylelint-config-recommended": "^14.0.1",
     "terser": "5.31.6",
     "tsconfig-paths": "^4.2.0",
-    "typescript-eslint": "^8.18.2",
+    "typescript-eslint": "^8.26.0",
     "webpack-dev-server": "5.2.0"
   },
   "resolutions": {
@@ -256,7 +256,7 @@
     "diff-docs": "yarn install-api-docs && ts-node api-docs/openapi-diff.ts",
     "deref-api-docs": "ts-node api-docs/index.ts tests/apidocs/openapi-spectacular.json tests/apidocs/openapi-derefed.json",
     "build-chartcuterie-config": "NODE_ENV=production webpack --config=config/webpack.chartcuterie.config.ts",
-    "build-acceptance": "IS_ACCEPTANCE_TEST=1 NODE_ENV=production webpack",
+    "build-acceptance": "CODECOV_ENABLE_BA=false IS_ACCEPTANCE_TEST=1 NODE_ENV=production webpack",
     "build-production": "NODE_ENV=production webpack --mode production",
     "build": "NODE_OPTIONS=--max-old-space-size=4096 webpack",
     "build-js-loader": "ts-node scripts/build-js-loader.ts",

src/sentry/api/endpoints/debug_files.py

@@ -478,7 +478,7 @@ def batch_assemble(project, files):
     checksums_to_check -= checksums_without_chunks
 
     # 4. Find missing chunks and group them per checksum.
-    all_missing_chunks = find_missing_chunks(project.organization, list(chunks_to_check.keys()))
+    all_missing_chunks = find_missing_chunks(project.organization.id, set(chunks_to_check.keys()))
 
     missing_chunks_per_checksum: dict[str, set[str]] = {}
     for chunk in all_missing_chunks:

src/sentry/api/endpoints/organization_artifactbundle_assemble.py

@@ -92,8 +92,8 @@ def post(self, request: Request, organization) -> Response:
             chunks = data.get("chunks", [])
 
             # We check if all requested chunks have been uploaded.
-            with sentry_sdk.start_span(op="artifact_bundle.assemble.find_missing_chunks"):
-                missing_chunks = find_missing_chunks(organization, chunks)
+            missing_chunks = find_missing_chunks(organization.id, set(chunks))
+
             # In case there are some missing chunks, we will tell the client which chunks we require.
             if missing_chunks:
                 return Response(

src/sentry/api/endpoints/seer_rpc.py

@@ -27,7 +27,7 @@
 from sentry.hybridcloud.rpc.service import RpcAuthenticationSetupException, RpcResolutionException
 from sentry.hybridcloud.rpc.sig import SerializableFunctionValueException
 from sentry.models.organization import Organization
-from sentry.seer.fetch_issues_given_patches import get_issues_related_to_file_patches
+from sentry.seer.fetch_issues.fetch_issues_given_patches import get_issues_related_to_file_patches
 from sentry.silo.base import SiloMode
 from sentry.utils.env import in_test_environment
 

src/sentry/debug_files/upload.py

@@ -1,31 +1,21 @@
-from collections.abc import Sequence
 from datetime import timedelta
 
 import sentry_sdk
 from django.utils import timezone
 
-from sentry import features
-from sentry.models.files import FileBlob, FileBlobOwner
-from sentry.models.organization import Organization
+from sentry.models.files import FileBlob
 
 
-def find_missing_chunks(organization: Organization, chunks: Sequence[str]):
+def find_missing_chunks(organization_id: int, chunks: set[str]):
     """Returns a list of chunks which are missing for an org."""
-    if features.has("organizations:find-missing-chunks-new", organization):
-        return _find_missing_chunks_new(organization.id, set(chunks))
-
-    return _find_missing_chunks_old(organization.id, set(chunks))
-
-
-def _find_missing_chunks_new(organization_id: int, chunks: set[str]):
-    with sentry_sdk.start_span(op="find_missing_chunks_new") as span:
+    with sentry_sdk.start_span(op="find_missing_chunks") as span:
         span.set_tag("organization_id", organization_id)
         span.set_data("chunks_size", len(chunks))
 
         if not chunks:
             return []
 
-        with sentry_sdk.start_span(op="find_missing_chunks_new.fetch_owned_file_blobs"):
+        with sentry_sdk.start_span(op="find_missing_chunks.fetch_owned_file_blobs"):
             owned_file_blobs = FileBlob.objects.filter(
                 checksum__in=chunks, fileblobowner__organization_id=organization_id
             ).values_list(
@@ -39,7 +29,7 @@ def _find_missing_chunks_new(organization_id: int, chunks: set[str]):
         owned_file_chunks = {checksum for _, checksum, _ in owned_file_blobs}
         unowned_file_chunks = chunks - owned_file_chunks
 
-        with sentry_sdk.start_span(op="find_missing_chunks_new.fetch_unowned_file_blobs"):
+        with sentry_sdk.start_span(op="find_missing_chunks.fetch_unowned_file_blobs"):
             unowned_file_blobs = FileBlob.objects.filter(
                 checksum__in=unowned_file_chunks,
             ).values_list(
@@ -65,27 +55,3 @@ def _find_missing_chunks_new(organization_id: int, chunks: set[str]):
 
         # We return all the file chunks that are not bound to the supply organization.
         return list(unowned_file_chunks)
-
-
-def _find_missing_chunks_old(organization_id: int, chunks: set[str]):
-    with sentry_sdk.start_span(op="find_missing_chunks_old") as span:
-        span.set_tag("organization_id", organization_id)
-        span.set_data("chunks_size", len(chunks))
-
-        now = timezone.now()
-        threshold = now - timedelta(hours=12)
-
-        with sentry_sdk.start_span(op="find_missing_chunks_old.update_timestamp"):
-            FileBlob.objects.filter(checksum__in=chunks, timestamp__lte=threshold).update(
-                timestamp=now
-            )
-
-        # Compute the set of all existing chunks.
-        with sentry_sdk.start_span(op="find_missing_chunks_old.get_owned_chunks"):
-            owned = set(
-                FileBlobOwner.objects.filter(
-                    blob__checksum__in=chunks, organization_id=organization_id
-                ).values_list("blob__checksum", flat=True)
-            )
-
-        return list(chunks - owned)

src/sentry/event_manager.py

@@ -2440,12 +2440,10 @@ def _calculate_span_grouping(jobs: Sequence[Job], projects: ProjectsMapping) ->
 
 
 @sentry_sdk.tracing.trace
-def _detect_performance_problems(
-    jobs: Sequence[Job], projects: ProjectsMapping, is_standalone_spans: bool = False
-) -> None:
+def _detect_performance_problems(jobs: Sequence[Job], projects: ProjectsMapping) -> None:
     for job in jobs:
         job["performance_problems"] = detect_performance_problems(
-            job["data"], projects[job["project_id"]], is_standalone_spans=is_standalone_spans
+            job["data"], projects[job["project_id"]]
         )
 
 

src/sentry/features/temporary.py

@@ -251,6 +251,8 @@ def register_temporary_features(manager: FeatureManager):
     manager.add("organizations:performance-trace-details", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
     # Enable trace explorer features
     manager.add("organizations:performance-trace-explorer", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
+    # Enable saved queries in trace explorer
+    manager.add("organizations:performance-saved-queries", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
     # Enable querying spans fields stats from comparative workflows project
     manager.add("organizations:performance-spans-fields-stats", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
     # Enable linking to trace explorer from metrics
@@ -488,13 +490,6 @@ def register_temporary_features(manager: FeatureManager):
     manager.add("organizations:ourlogs-ingestion", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
     # Enable updated form for 3p publishing flow
     manager.add("organizations:streamlined-publishing-flow", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
-    # Enable new find missing chunks algorithm
-    manager.add(
-        "organizations:find-missing-chunks-new",
-        OrganizationFeature,
-        FeatureHandlerStrategy.FLAGPOLE,
-        api_expose=False
-    )
     # Enable per-project selection for Jira integration
     manager.add("organizations:jira-per-project-statuses", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False)
     # Enable Relay extracting logs from breadcrumbs for a project.

src/sentry/hybridcloud/tasks/deliver_webhooks.py

@@ -5,7 +5,7 @@
 
 import orjson
 import sentry_sdk
-from django.db.models import Min, Subquery
+from django.db.models import Case, CharField, Min, Subquery, Value, When
 from django.utils import timezone
 from requests import Response
 from requests.models import HTTPError
@@ -58,6 +58,14 @@
 actions that have been made to the relevant resources.
 """
 
+# Define priorities for different webhook providers
+# Lower number means higher priority
+PROVIDER_PRIORITY = {
+    "stripe": 1,
+}
+# Default priority for providers not explicitly listed above
+DEFAULT_PROVIDER_PRIORITY = 10
+
 
 class DeliveryFailed(Exception):
     """
@@ -77,25 +85,47 @@ def schedule_webhook_delivery(**kwargs: Never) -> None:
     Find mailboxes that contain undelivered webhooks that were scheduled
     to be delivered now or in the past.
 
+    Prioritizes webhooks based on provider importance.
+
     Triggered frequently by celery beat.
     """
-    # The double call to .values() ensures that the group by includes mailbox_nam
+    # The double call to .values() ensures that the group by includes mailbox_name
     # but only id_min is selected
     head_of_line = (
         WebhookPayload.objects.all()
         .values("mailbox_name")
         .annotate(id_min=Min("id"))
         .values("id_min")
     )
+
     # Get any heads that are scheduled to run
-    scheduled_mailboxes = WebhookPayload.objects.filter(
-        schedule_for__lte=timezone.now(),
-        id__in=Subquery(head_of_line),
-    ).values("id", "mailbox_name")
+    # Use provider field directly, with default priority for null values
+    scheduled_mailboxes = (
+        WebhookPayload.objects.filter(
+            schedule_for__lte=timezone.now(),
+            id__in=Subquery(head_of_line),
+        )
+        # Set priority value based on provider field
+        .annotate(
+            provider_priority=Case(
+                # For providers that match our priority list
+                *[
+                    When(provider=provider, then=Value(priority))
+                    for provider, priority in PROVIDER_PRIORITY.items()
+                ],
+                # Default value for all other cases (including null providers)
+                default=Value(DEFAULT_PROVIDER_PRIORITY),
+                output_field=CharField(),
+            )
+        )
+        # Order by priority first (lowest number = highest priority), then ID
+        .order_by("provider_priority", "id").values("id", "mailbox_name")
+    )
 
     metrics.distribution(
         "hybridcloud.schedule_webhook_delivery.mailbox_count", scheduled_mailboxes.count()
     )
+
     for record in scheduled_mailboxes[:BATCH_SIZE]:
         # Reschedule the records that we will attempt to deliver next.
         # We update schedule_for in an attempt to minimize races for potentially in-flight batches.