Drop kernel.build_dir param below Symfony 5.2 (#711)

Co-authored-by: Michi Hoffmann <[email protected]>

Author: Jean85

src/DependencyInjection/Configuration.php

@@ -15,6 +15,7 @@
 use Symfony\Component\Config\Definition\Builder\TreeBuilder;
 use Symfony\Component\Config\Definition\ConfigurationInterface;
 use Symfony\Component\HttpClient\HttpClient;
+use Symfony\Component\HttpKernel\Kernel;
 use Symfony\Component\Messenger\MessageBusInterface;
 
 final class Configuration implements ConfigurationInterface
@@ -31,6 +32,15 @@ public function getConfigTreeBuilder(): TreeBuilder
             ? $treeBuilder->getRootNode()
             : $treeBuilder->root('sentry');
 
+        $inAppExcludes = [
+            '%kernel.cache_dir%',
+            '%kernel.project_dir%/vendor',
+        ];
+
+        if (Kernel::VERSION_ID >= 50200) {
+            $inAppExcludes[] = '%kernel.build_dir%';
+        }
+
         $rootNode
             ->children()
                 ->scalarNode('dsn')
@@ -116,11 +126,7 @@ public function getConfigTreeBuilder(): TreeBuilder
                         ->arrayNode('in_app_exclude')
                             ->scalarPrototype()->end()
                             ->beforeNormalization()->castToArray()->end()
-                            ->defaultValue([
-                                '%kernel.cache_dir%',
-                                '%kernel.build_dir%',
-                                '%kernel.project_dir%/vendor',
-                            ])
+                            ->defaultValue($inAppExcludes)
                         ->end()
                         ->arrayNode('in_app_include')
                             ->scalarPrototype()->end()

tests/DependencyInjection/ConfigurationTest.php

@@ -13,6 +13,7 @@
 use Symfony\Component\Config\Definition\Exception\InvalidConfigurationException;
 use Symfony\Component\Config\Definition\Processor;
 use Symfony\Component\HttpClient\HttpClient;
+use Symfony\Component\HttpKernel\Kernel;
 use Symfony\Component\Messenger\MessageBusInterface;
 
 final class ConfigurationTest extends TestCase
@@ -33,8 +34,8 @@ public function testProcessConfigurationWithDefaultConfiguration(): void
                 'tags' => [],
                 'in_app_exclude' => [
                     '%kernel.cache_dir%',
-                    '%kernel.build_dir%',
                     '%kernel.project_dir%/vendor',
+                    '%kernel.build_dir%',
                 ],
                 'in_app_include' => [],
                 'class_serializers' => [],
@@ -64,6 +65,11 @@ public function testProcessConfigurationWithDefaultConfiguration(): void
             ],
         ];
 
+        if (Kernel::VERSION_ID < 50200) {
+            array_pop($expectedBundleDefaultConfig['options']['in_app_exclude']);
+            $this->assertNotContains('%kernel.build_dir%', $expectedBundleDefaultConfig['options']['in_app_exclude'], 'Precondition failed, wrong default removed');
+        }
+
         $this->assertSame($expectedBundleDefaultConfig, $this->processConfiguration([]));
     }