Skip to content

Commit 935fd6e

Browse files
committed
Avoid double-reporting of CLI errors
1 parent ae13f2a commit 935fd6e

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
66

77
## [Unreleased]
88

9+
## 2.0.1 - TBA
10+
### Fixed
11+
- Avoid reporting CLI errors twice (#104)
12+
913
## 2.0.0 - 2017-12-12
1014
### Added
1115
- Add support for Symfony 4.x

src/Resources/config/services.yml

-1
Original file line numberDiff line numberDiff line change
@@ -18,5 +18,4 @@ services:
1818
- { name: kernel.event_listener, event: kernel.request, method: onKernelRequest, priority: '%sentry.listener_priorities.request%'}
1919
- { name: kernel.event_listener, event: kernel.exception, method: onKernelException, priority: '%sentry.listener_priorities.kernel_exception%' }
2020
- { name: kernel.event_listener, event: console.command, method: onConsoleCommand }
21-
- { name: kernel.event_listener, event: console.exception, method: onConsoleException, priority: '%sentry.listener_priorities.console_exception%' }
2221
- { name: kernel.event_listener, event: console.error, method: onConsoleError, priority: '%sentry.listener_priorities.console_exception%' }

test/DependencyInjection/SentryExtensionTest.php

-5
Original file line numberDiff line numberDiff line change
@@ -287,11 +287,6 @@ public function test_that_it_has_proper_event_listener_tags_for_exception_listen
287287
'priority' => '%sentry.listener_priorities.kernel_exception%',
288288
],
289289
['event' => 'console.command', 'method' => 'onConsoleCommand'],
290-
[
291-
'event' => 'console.exception',
292-
'method' => 'onConsoleException',
293-
'priority' => '%sentry.listener_priorities.console_exception%',
294-
],
295290
[
296291
'event' => 'console.error',
297292
'method' => 'onConsoleError',

0 commit comments

Comments
 (0)