Trim DSN config value

Author: Jean85

CHANGELOG.md

@@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
+## 0.8.5 - 2017-08-22
+### Fixed
+ - `trim()` DSN value from config, to avoid issues with .env files on BitBucket (see https://github.com/getsentry/sentry-symfony/pull/21#issuecomment-323673938)
+
 ## 0.8.4 - 2017-08-08
 ### Fixed
  - Fix exception being thrown when both deprecated and new options are used.

src/Sentry/SentryBundle/DependencyInjection/Configuration.php

@@ -23,6 +23,14 @@ public function getConfigTreeBuilder()
     {
         $treeBuilder = new TreeBuilder();
         $rootNode = $treeBuilder->root('sentry');
+        $trimClosure = function ($str) {
+            $value = trim($str);
+            if ($value === '') {
+                return null;
+            }
+
+            return $value;
+        };
 
         $rootNode
             ->children()
@@ -36,6 +44,10 @@ public function getConfigTreeBuilder()
                     ->defaultValue('%kernel.environment%')
                 ->end()
                 ->scalarNode('dsn')
+                    ->beforeNormalization()
+                        ->ifString()
+                        ->then($trimClosure)
+                    ->end()
                     ->defaultNull()
                 ->end()
                 ->arrayNode('options')

test/DependencyInjection/SentryExtensionTest.php

@@ -194,6 +194,32 @@ public function test_that_it_uses_null_as_dsn_default_value()
         );
     }
 
+    /**
+     * @dataProvider emptyDsnValueProvider
+     */
+    public function test_that_it_ignores_empty_dsn_value($emptyDsn)
+    {
+        $container = $this->getContainer(
+            array(
+                static::CONFIG_ROOT => array(
+                    'dsn' => $emptyDsn,
+                ),
+            )
+        );
+
+        $this->assertNull($container->getParameter('sentry.dsn'));
+    }
+
+    public function emptyDsnValueProvider()
+    {
+        return array(
+            array(null),
+            array(''),
+            array(' '),
+            array('    '),
+        );
+    }
+
     public function test_that_it_uses_dsn_value()
     {
         $container = $this->getContainer(