Skip to content

Commit 4f931bd

Browse files
authored
Use a reliability enum instead of boolean (#65)
* Use a reliability enum instead of boolean * swap reliabilities
1 parent 88228f5 commit 4f931bd

File tree

3 files changed

+10
-2
lines changed

3 files changed

+10
-2
lines changed

proto/sentry_protos/snuba/v1/endpoint_time_series.proto

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,9 @@ message DataPoint {
2020
// optional, if not set, assume true. Accounts for sparse time series
2121
bool data_present = 2;
2222
float avg_sampling_rate = 3;
23-
bool is_reliable = 4;
24-
// determines whether the aggregation is reliable using math based on confidence intervals and sample size
23+
bool is_reliable = 4 [deprecated = true];
24+
// determines the reliability of the aggregation using math based on confidence intervals and sample size
25+
Reliability reliability = 5;
2526
}
2627

2728
message TimeSeries {

proto/sentry_protos/snuba/v1/endpoint_trace_item_table.proto

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ message Column {
3434
message TraceItemColumnValues {
3535
string attribute_name = 1;
3636
repeated AttributeValue results = 2;
37+
repeated Reliability reliabilities = 3;
3738
}
3839

3940
message TraceItemTableResponse {

proto/sentry_protos/snuba/v1/trace_item_attribute.proto

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,3 +83,9 @@ message AttributeAggregation {
8383
string label = 3;
8484
ExtrapolationMode extrapolation_mode = 4;
8585
}
86+
87+
enum Reliability {
88+
RELIABILITY_UNSPECIFIED = 0;
89+
RELIABILITY_LOW = 1;
90+
RELIABILITY_HIGH = 2;
91+
}

0 commit comments

Comments
 (0)