Use a reliability enum instead of boolean (#65)

* Use a reliability enum instead of boolean * swap reliabilities
getsentry · Nov 18, 2024 · 4f931bd · 4f931bd
1 parent 88228f5
commit 4f931bd
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/proto/sentry_protos/snuba/v1/endpoint_time_series.proto b/proto/sentry_protos/snuba/v1/endpoint_time_series.proto
@@ -20,8 +20,9 @@ message DataPoint {
   // optional, if not set, assume true. Accounts for sparse time series
   bool data_present = 2;
   float avg_sampling_rate = 3;
-  bool is_reliable = 4;
-  // determines whether the aggregation is reliable using math based on confidence intervals and sample size
+  bool is_reliable = 4 [deprecated = true];
+  // determines the reliability of the aggregation using math based on confidence intervals and sample size
+  Reliability reliability = 5;
 }
 
 message TimeSeries {

diff --git a/proto/sentry_protos/snuba/v1/endpoint_trace_item_table.proto b/proto/sentry_protos/snuba/v1/endpoint_trace_item_table.proto
@@ -34,6 +34,7 @@ message Column {
 message TraceItemColumnValues {
   string attribute_name = 1;
   repeated AttributeValue results = 2;
+  repeated Reliability reliabilities = 3;
 }
 
 message TraceItemTableResponse {

diff --git a/proto/sentry_protos/snuba/v1/trace_item_attribute.proto b/proto/sentry_protos/snuba/v1/trace_item_attribute.proto
@@ -83,3 +83,9 @@ message AttributeAggregation {
   string label = 3;
   ExtrapolationMode extrapolation_mode = 4;
 }
+
+enum Reliability {
+  RELIABILITY_UNSPECIFIED = 0;
+  RELIABILITY_LOW = 1;
+  RELIABILITY_HIGH = 2;
+}