checkInId in Sentry.withMonitor

[danilofuchs]

Problem Statement

Would be nice to be able to set our own id for a cron job execution, as we have a cross-referenceable uuid for that.

It is available under captureCheckIn({checkInId: ourId}) but not on withMonitor(name, handler)

Solution Brainstorm

Change the first parameter from name, to options, with both properties

[AbhiPrasad]

@danilofuchs sounds like a good idea. PRs are welcome!

[danilofuchs]

I'll send a PR soon!

[lforst]

@AbhiPrasad Are we sure that this is a good idea? I think checkin ids should mostly be abstracted away when using withMonitor and that tags and contexts will be a better mechanism to associate other entities with a cron job...

[danilofuchs]

@AbhiPrasad Are we sure that this is a good idea? I think checkin ids should mostly be abstracted away when using withMonitor and that tags and contexts will be a better mechanism to associate other entities with a cron job...

I agree tags and context would make much more sense!

[AbhiPrasad]

Hey @danilofuchs - we created a GH issue to track adding tags/contexts to crons: getsentry/sentry#60741

please leave your thoughts there! For now I'm going to close this issue in favour of that.