Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Monitoring for Web Streams (Response API) #9633

Open
lforst opened this issue Nov 22, 2023 · 0 comments
Open

Performance Monitoring for Web Streams (Response API) #9633

lforst opened this issue Nov 22, 2023 · 0 comments
Labels
Feature: Spans Migrated Package: core Issues related to the Sentry Core SDK

Comments

@lforst
Copy link
Member

lforst commented Nov 22, 2023

This was originally raised in #9626

We currently don't track the performance of web streams well. What does count as web streams? Basically everything that returns data in chunks (probably even normal http responses too):

  • Websockets
  • Server Sent Events
  • Video streams
  • etc.

In node we do this reasonably well because we hook into res.end() which generally marks the end of a Stream, however, we need to improve the WinterCG case with Response. The reader seems to have a done property on stream chunks that we could use to mark the end of the stream.

@lforst lforst added the Package: core Issues related to the Sentry Core SDK label Nov 22, 2023
@lforst lforst changed the title Performance with Web Streams Performance Monitoring for Web Streams Nov 22, 2023
@lforst lforst changed the title Performance Monitoring for Web Streams Performance Monitoring for Web Streams (fetch) Nov 22, 2023
@lforst lforst changed the title Performance Monitoring for Web Streams (fetch) Performance Monitoring for Web Streams (Response API) Nov 22, 2023
@linear linear bot added the Migrated label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Spans Migrated Package: core Issues related to the Sentry Core SDK
Projects
None yet
Development

No branches or pull requests

2 participants