-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation transactions not triggering for hash router #9592
Comments
@onurtemizkan can you dig into this when you get time? |
@AbhiPrasad, I have just tried to reproduce the issue, and it looks like both usages of wrapping One thing I suspect that may cause this behaviour is, initialising the SDK, but not instrumenting the hash router/routes properly. The For the rest of the functionality: // We can instrument `createHashRouter` with `Sentry.wrapCreateBrowserRouter(...)`
const sentryCreateHashRouter =
Sentry.wrapCreateBrowserRouter(createHashRouter);
const router = sentryCreateHashRouter([
// ...
]); or const SentryRoutes = Sentry.withSentryReactRouterV6Routing(Routes);
ReactDOM.render(
<HashRouter>
<SentryRoutes>
<Route path="/" element={<div>Home</div>} />
</SentryRoutes>
</HashRouter>
); are needed. Could you let me know if that's the case? |
The user was using |
Interesting, I'll try to reproduce this on a deployed app 👍 |
I'm still not able to reproduce the issue on an app deployed to Vercel: https://react-router-v6-sentry-trial-gjq5.vercel.app/ |
Is there an existing issue for this?
How do you use Sentry?
Sentry Saas (sentry.io)
Which SDK are you using?
@sentry/react
SDK Version
7.73.0
Framework Version
No response
Link to Sentry event
No response
SDK Setup
Using React Router v6 instrumentation + hash router
Steps to Reproduce
enable sdk. See SDK is only generating pageloads not navigations
Expected Result
Sentry generates transactions for navigations
Actual Result
location seems to be changing just fine.
The text was updated successfully, but these errors were encountered: