-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options to make name
and email
fields required
#9479
Comments
@c298lee I'd recommend looking over some of the existing tests and maybe starting off with a test case - this should let you get started quicker than setting up local dev env (though I can help you with that too). For local dev: Setup
WorkflowWhen you're actively developing, I like to:
|
There is a bug with export const sentryFeedback = new Feedback({
autoInject: false,
isAnonymous: false,
showBranding: false,
isNameRequired: true,
isEmailRequired: true,
colorScheme: 'system',
}) |
@hckhanh yes this is not implemented yet, it was mistakenly added in the types |
Currently only the description is required. We should add options to make either name and/or email as required fields.
Note that we have
showName
andshowEmail
options which only hides the input fields (but can still send the name/email values if they are set in Sentry core SDK). The "required" state should only be enforced if the UI elements are visible -- (or rather, disregard theshow*
if required is set).The text was updated successfully, but these errors were encountered: