-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore rage/dead clicks from download links #9087
Comments
You can already manually ignore selectors via If so, there are two ways I guess:
slowClickIgnoreSelectors: [
'[aria-label*="download" i]',
'[aria-label*="export" i]',
'[title*="download" i]',
'[title*="export" i]',
]
IMHO 1. is pretty easily doable, I think we could start with |
Ah yeah let's start with #1 before we make it as a default for SDK |
Added this to sentry's config in https://github.com/getsentry/getsentry/pull/11728 -- we can re-open if we want to make this default for sdk. |
Currently, we are getting false positive dead/rage clicks from download links because they don't mutate the DOM in any way. There's no standardized or semantic way to identify these download links, but I think we can look at it from an a11y approach and ignore some aria attribute values that contain
Download
orExport
.Some possible attribute candidates:
aria-label
,aria-roledescription
The text was updated successfully, but these errors were encountered: