Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v9] Fix React Error Boundary typing for componentStack #14310

Open
AbhiPrasad opened this issue Nov 14, 2024 · 3 comments · May be fixed by #14742
Open

[v9] Fix React Error Boundary typing for componentStack #14310

AbhiPrasad opened this issue Nov 14, 2024 · 3 comments · May be fixed by #14742
Assignees
@AbhiPrasad
Labels
Package: react Issues related to the Sentry React SDK

Comments

@AbhiPrasad
Copy link
Member

Description

sentry-javascript/packages/react/src/errorboundary.tsx

Lines 101 to 102 in 5b77377

// TODO(v9): Remove this check and type `componentStack` to be React.ErrorInfo['componentStack'].
const passedInComponentStack: string | undefined = componentStack == null ? undefined : componentStack;

@AbhiPrasad AbhiPrasad added the Package: react Issues related to the Sentry React SDK label Nov 14, 2024
@kunal-511
Copy link

kunal-511 commented Nov 16, 2024 •
edited by andreiborza
Loading

@AbhiPrasad I have raised PR for this issue. Please have a look: #14327

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Nov 16, 2024
@andreiborza
Copy link
Member

hey @kunal-511 thanks for contributing this. We'll take a look.

@AbhiPrasad
Copy link
Member Author

This can only be merged in once v9 is being actively worked on.

@AbhiPrasad AbhiPrasad linked a pull request Dec 16, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AbhiPrasad AbhiPrasad

Labels
Package: react Issues related to the Sentry React SDK
Projects
GitHub Issues with 👀 3
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(react)!: Update ErrorBoundary componentStack type getsentry/sentry-javascript
3 participants
@AbhiPrasad @kunal-511 @andreiborza