Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify setup code for OpenFeatureIntegration #14645

Open
aliu39 opened this issue Dec 10, 2024 · 0 comments
Open

Simplify setup code for OpenFeatureIntegration #14645

aliu39 opened this issue Dec 10, 2024 · 0 comments
Assignees
Labels
Feature: Feature Flags Issues related to Sentry Feature Flags Support

Comments

@aliu39
Copy link
Member

aliu39 commented Dec 10, 2024

Description

Like in python, we can call addHooks in the integration's setup method, optionally taking in an OpenFeature client. With this the user no longer has to call addHooks manually, and setup will match what we have for most integrations.

Current setup code

This shouldn't be done immediately since the integration was just released in 8.43. However it's still considered open beta, so this can be done before GA.

Pros:

  • less setup code for users, less chance for error

Cons:

  • inconsistent with LD setup code, where this separate call is necessary. This isn't much of a con IMO, because we expect providers to be different, it's more important to have JS and Python consistent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Feature Flags Issues related to Sentry Feature Flags Support
Projects
Status: Todo
Development

No branches or pull requests

2 participants