Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@sentry/angular] Update Angular to v19 #14386

Closed
3 tasks done
msrumon opened this issue Nov 20, 2024 · 3 comments · Fixed by #14398
Closed
3 tasks done

[@sentry/angular] Update Angular to v19 #14386

msrumon opened this issue Nov 20, 2024 · 3 comments · Fixed by #14398
Assignees
Labels
Package: angular Issues related to the Sentry Angular SDK

Comments

@msrumon
Copy link

msrumon commented Nov 20, 2024

Is there an existing issue for this?

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using?

@sentry/angular

SDK Version

8.39.0

Framework Version

Angular 19.0.0

Link to Sentry event

No response

Reproduction Example/SDK Setup

No response

Steps to Reproduce

Run npm i @sentry/angular in any Angular v19 project.

I'm happy to send PR if needed.

Expected Result

found 0 vulnerabilities

Actual Result

npm error Found: @angular/[email protected]
npm error node_modules/@angular/common
npm error   @angular/common@"^19.0.0" from the root project
npm error
npm error Could not resolve dependency:
npm error peer @angular/common@">= 14.x <= 18.x" from @sentry/[email protected]
npm error node_modules/@sentry/angular
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Nov 20, 2024
@github-actions github-actions bot added the Package: angular Issues related to the Sentry Angular SDK label Nov 20, 2024
@Lms24
Copy link
Member

Lms24 commented Nov 20, 2024

Hi, thanks for writing in! I'll take a look tomorrow and will update the peer dependencies asap (hopefully). In the meantime, you should be able to install the SDK using the --force argument

@Lms24
Copy link
Member

Lms24 commented Nov 21, 2024

Hi, quick update: I bumped our peer dependencies and will release the changes soon

Copy link
Contributor

A PR closing this issue has just been released 🚀

This issue was referenced by PR #14398, which was included in the 8.40.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: angular Issues related to the Sentry Angular SDK
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants