Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update remaining usage of request on SDK processing metadata #14298

Closed
17 tasks done
mydea opened this issue Nov 14, 2024 · 0 comments · Fixed by #14401
Closed
17 tasks done

Update remaining usage of request on SDK processing metadata #14298

mydea opened this issue Nov 14, 2024 · 0 comments · Fixed by #14401
Assignees

Comments

@mydea
Copy link
Member

mydea commented Nov 14, 2024

Description

We have recently introduced a new way to set request data, which is based on normalizedRequest, which is pre-processed. We already use this in node for http, but there are some remaining usages where we still set request that we have to update to instead set normalizedRequest:

  • astro/src/server/middleware.ts
  • bun/src/integrations/bunserver.ts
  • cloudflare/src/scope-utils.ts
  • google-cloud-serverless/src/gcpfunction/http.ts
  • nextjs/src/common/captureRequestError.ts
  • nextjs/src/common/withServerActionInstrumentation.ts
  • nextjs/src/common/wrapGenerationFunctionWithSentry.ts
  • nextjs/src/common/wrapMiddlewareWithSentry.ts
  • nextjs/src/common/wrapRouteHandlerWithSentry.ts
  • nextjs/src/common/wrapServerComponentWithSentry.ts
  • nextjs/src/common/pages-router-instrumentation/_error.ts
  • nextjs/src/common/pages-router-instrumentation/wrapApiHandlerWithSentry.ts
  • nextjs/src/common/utils/wrapperUtils.ts
  • nextjs/src/edge/wrapApiHandlerWithSentry.ts
  • remix/src/utils/errors.ts
  • remix/src/utils/instrumentServer.ts
  • sveltekit/src/server/handle.ts
mydea added a commit that referenced this issue Nov 14, 2024
The request data integration prefers this over `request`, we want to get rid of `request` in v9.

Part of #14298
mydea added a commit that referenced this issue Nov 15, 2024
The request data integration prefers this over `request`, we want to get rid of `request` in v9.

Part of #14298

url should not be set on server-components
mydea added a commit that referenced this issue Nov 15, 2024
The request data integration prefers this over `request`, we want to get rid of `request` in v9.

Part of #14298
mydea added a commit that referenced this issue Nov 20, 2024
…14305)

The request data integration prefers this over `request`, we want to get
rid of `request` in v9.

Updates the following:

- [x] astro/src/server/middleware.ts
- [x] bun/src/integrations/bunserver.ts
- [x] cloudflare/src/scope-utils.ts
- [ ] google-cloud-serverless/src/gcpfunction/http.ts
- [x] nextjs/src/common/captureRequestError.ts
- [x] nextjs/src/common/withServerActionInstrumentation.ts
- [x] nextjs/src/common/wrapGenerationFunctionWithSentry.ts
- [ ] nextjs/src/common/wrapMiddlewareWithSentry.ts
- [x] nextjs/src/common/wrapRouteHandlerWithSentry.ts
- [x] nextjs/src/common/wrapServerComponentWithSentry.ts
- [ ] nextjs/src/common/pages-router-instrumentation/_error.ts
- [ ]
nextjs/src/common/pages-router-instrumentation/wrapApiHandlerWithSentry.ts
- [ ] nextjs/src/common/utils/wrapperUtils.ts
- [x] nextjs/src/edge/wrapApiHandlerWithSentry.ts
- [ ] remix/src/utils/errors.ts
- [ ] remix/src/utils/instrumentServer.ts
- [x] sveltekit/src/server/handle.ts

Part of #14298
mydea added a commit that referenced this issue Nov 21, 2024
…4401)

This includes exporting `httpRequestToRequestEventData` from
`@sentry/node`, which we can reuse in a few places.

This also allows us to remove a bunch of stuff from remix, because
actually we can just use `winterCGRequestToRequestData` instead of the
custom implementation we have there. at least type wise, this should all
work, let's see if any test complains...

Closes #14298
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant