Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Flags] Support multi-client configs for browser SDKs #14281

Closed
aliu39 opened this issue Nov 13, 2024 · 3 comments
Closed

[Feature Flags] Support multi-client configs for browser SDKs #14281

aliu39 opened this issue Nov 13, 2024 · 3 comments
Assignees
Labels
Feature: Feature Flags Issues related to Sentry Feature Flags Support

Comments

@aliu39
Copy link
Member

aliu39 commented Nov 13, 2024

Description

https://docs.sentry.io/platforms/javascript/best-practices/shared-environments/
The browser may have >1 Sentry client per SDK instance. The most common case seems to be browser extensions. We could support this case by isolating flags from different clients, maintaining a WeakMap of <Client, flag evaluations>.

@aliu39 aliu39 changed the title Support multi-client environments for browser SDKs [Feature Flags] Support multi-client environments for browser SDKs Nov 13, 2024
@aliu39 aliu39 changed the title [Feature Flags] Support multi-client environments for browser SDKs [Feature Flags] Support multi-client configs for browser SDKs Nov 13, 2024
@mydea
Copy link
Member

mydea commented Nov 14, 2024

Just some thoughts, generally in such scenarios we do not support global things very well overall. There are a lot of integrations etc. that do not work in such global settings (meaning, they only work for the "main" global app, but not e.g. the browser extension), and it can be a reasonable solution to say that a certain feature is not fully supported in e.g. a browser extension. Not saying this is what we should do, just wanted to point out that sometimes it is simply not really doable well, sadly, so we don't always have a choice :(

@AbhiPrasad AbhiPrasad added the Feature: Feature Flags Issues related to Sentry Feature Flags Support label Dec 11, 2024
@aliu39
Copy link
Member Author

aliu39 commented Dec 17, 2024

Thanks for the thoughts @mydea , I think the last time I talked about this with @cmanallen , he saw it as an edge case we won't prioritize until popularly requested. I made this ticket as a reminder, but we might end up just not doing it

@aliu39
Copy link
Member Author

aliu39 commented Dec 23, 2024

Due the reasons above, I'll close this as won't do in the near future. The effort to change our implementation is pretty high for an edge case

@aliu39 aliu39 closed this as completed Dec 23, 2024
@aliu39 aliu39 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Feature Flags Issues related to Sentry Feature Flags Support
Projects
Status: Done
Development

No branches or pull requests

3 participants