From 083594eba7527e8468b034bd45d1730b3a553823 Mon Sep 17 00:00:00 2001 From: JonasBa Date: Mon, 2 Dec 2024 12:49:42 -0500 Subject: [PATCH] try running directly --- .github/workflows/build.yml | 4 +++- .../e2e-tests/test-applications/node-profiling/index.mjs | 2 ++ .../e2e-tests/test-applications/node-profiling/package.json | 4 ++-- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index dbf0ad1e7027..2773c5943052 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -1205,8 +1205,10 @@ jobs: - name: Run E2E test working-directory: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }} timeout-minutes: 10 - run: + run: | xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- yarn test:assert + npm pkg set type=module + node index.mjs job_required_jobs_passed: name: All required jobs passed or were skipped diff --git a/dev-packages/e2e-tests/test-applications/node-profiling/index.mjs b/dev-packages/e2e-tests/test-applications/node-profiling/index.mjs index ad2e950131ca..6ab088e13d4a 100644 --- a/dev-packages/e2e-tests/test-applications/node-profiling/index.mjs +++ b/dev-packages/e2e-tests/test-applications/node-profiling/index.mjs @@ -29,3 +29,5 @@ Sentry.startSpan({ name: 'Precompile test' }, async () => { }); assertUnpatechedRequire(); + +console.log('✅ Require is not patched'); diff --git a/dev-packages/e2e-tests/test-applications/node-profiling/package.json b/dev-packages/e2e-tests/test-applications/node-profiling/package.json index 02e4c3a96f0e..2029ac1370ed 100644 --- a/dev-packages/e2e-tests/test-applications/node-profiling/package.json +++ b/dev-packages/e2e-tests/test-applications/node-profiling/package.json @@ -5,12 +5,12 @@ "scripts": { "typecheck": "tsc --noEmit", "build": "node build.mjs && node build.shimmed.mjs", - "test": "node dist/index.js && node --experimental-require-module dist/index.js && node dist/index.shimmed.mjs && pnpm run test:mjs", + "test": "node dist/index.js && node --experimental-require-module dist/index.js && node dist/index.shimmed.mjs", "clean": "npx rimraf node_modules dist", "test:electron": "$(pnpm bin)/electron-rebuild && playwright test", "test:build": "pnpm run typecheck && pnpm run build", "test:assert": "pnpm run test && pnpm run test:electron", - "test:mjs": "node --version && npm pkg set type=module && node index.mjs" + "test:mjs": "node index.mjs" }, "dependencies": { "@electron/rebuild": "^3.7.0",