-
-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SentryApolloInterceptor implements ApolloInterceptor but crashes app #3661
Comments
@DroidPulkit it looks like Apollo v4 introduced a change which breaks our interceptor. By any chance, did you try with Apollo v3 as well? |
Created an issue for implementing Apollo4 support: #3662 |
Closing in favor of #3662 |
Yeah for Apollo v3, I was using sentry-apollo3 library, I presumed, that when apollo changed their package name from apollo3 to apollo, after v4 upgrade, you folks at sentry did too. That's the reason, I choose, the sentry-apollo library. |
@DroidPulkit thanks for the input, I agree it's a bit confusing atm - we updated the docs on our Apollo/Apollo3 integrations to clarify which Apollo versions they support, and we'll likely (need to) introduce a new Apollo4 integration later |
Integration
sentry-android
Build System
Gradle
AGP Version
8.5.0
Proguard
Enabled
Version
7.14.0
Steps to Reproduce
Expected Result
App should run, right?
Actual Result
App crashes why?
SentryApolloInterceptor implements ApolloInterceptor.
What is ApolloInterceptor?
We have
override fun interceptAsync()
instead ofoverride fun intercept()
in SentryApolloInterceptor class, which leads to following crash:The text was updated successfully, but these errors were encountered: