Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTel] Add "instrumenter" configuration option #556

Closed
tonyo opened this issue Jan 30, 2023 · 1 comment
Closed

[OTel] Add "instrumenter" configuration option #556

tonyo opened this issue Jan 30, 2023 · 1 comment
Labels
Status: Backlog Topic: OpenTelemetry Issue/PR related to OpenTelemetry integration Type: Bug

Comments

@tonyo
Copy link
Contributor

tonyo commented Jan 30, 2023

Extracted from #537.

In other SDKs, there's "instrumenter" configuration in ClientOptions -- we need to confirm whether we need that.

@tonyo
Copy link
Contributor Author

tonyo commented Jan 31, 2023

"instrumenter" attribute in Sentry.Init in other SDKs (e.g. in Python, JavaScript) is basically used to control which automatic instrumentation should be used, to avoid double instrumentation in certain scenarios (for example, when we have a framework that is instrumented by both Sentry and OpenTelemetry).

Since the Sentry instrumentation we support for Go is mostly manual, we don't really need the "instrumenter" option right now: there are OpenTelemetry instrumentation libraries for a much bigger number of libraries/frameworks, so people should just use those (if they already use OTel), and Sentry-OTel bridge will take care of everything else.

@tonyo tonyo closed this as not planned Won't fix, can't repro, duplicate, stale Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Backlog Topic: OpenTelemetry Issue/PR related to OpenTelemetry integration Type: Bug
Projects
None yet
Development

No branches or pull requests

1 participant