Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTel] Dynamic Sampling Context propagation does not work for nested spans #553

Closed
tonyo opened this issue Jan 30, 2023 · 0 comments · Fixed by #559
Closed

[OTel] Dynamic Sampling Context propagation does not work for nested spans #553

tonyo opened this issue Jan 30, 2023 · 0 comments · Fixed by #559
Labels
Status: Backlog Topic: OpenTelemetry Issue/PR related to OpenTelemetry integration Type: Bug
Milestone

Comments

@tonyo
Copy link
Contributor

tonyo commented Jan 30, 2023

Extracted from #537.

Problem

Dynamic Sampling Context propagation from nested spans doesn't work properly in OpenTelemetry integration.
Main reason: no publicly exposed mechanism to get the transaction (as in, a root span) for the given nested span.
At the moment we're doing this, meaning that if we're doing a cross-service request from a nested span, the DSC won't be properly set.

Potential Solutions

  • Expose a method on Span that allows to get the root span (transaction) of the given span.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Backlog Topic: OpenTelemetry Issue/PR related to OpenTelemetry integration Type: Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants