Skip to content

Reduce dependencies #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 tasks done
bruno-garcia opened this issue Sep 4, 2020 · 6 comments
Closed
4 tasks done

Reduce dependencies #498

bruno-garcia opened this issue Sep 4, 2020 · 6 comments
Labels
Feature New feature or request

Comments

@bruno-garcia
Copy link
Member

bruno-garcia commented Sep 4, 2020

This will likely become multiple issues but for now to communicate the long term goal:

Vision: Have 0 dependencies.

This will improve the experience using Sentry with game engines, mobile. Avoid binding redirect issues with .NET Framework, and generally improve things.

  • Move code from Sentry.Protocol to namespace Sentry.Protocol in Sentry. Archive package on NuGet. Move SentryLevel to Sentry namespace
  • Move code from Sentry.PlatformAbstractions to Sentry (drop anything below ns2.0 and net461). Archive repo and project. First attempt is here: ref: platform abstraction in box #264

- [ ] Attempt to use System.Json (since it's not a dependency on netcore3.0+) See: getsentry/sentry-dotnet-protocol#42 dotnet/runtime#29975 (maybe .NET 5 introduces a easy way into it) (Seems we'll be blocked by the lack of JsonExtensionData)

RROR: get_assembly_dependencies: Cannot load assembly (refonly): 'System.Web'.
   At: modules/mono/editor/godotsharp_export.cpp:93.
ERROR: get_assembly_dependencies: Cannot load one of the dependencies for the assembly: 'Sentry'.
   At: modules/mono/editor/godotsharp_export.cpp:98.
@bruno-garcia bruno-garcia changed the title Reduce dependencies: Reduce dependencies Sep 4, 2020
@bruno-garcia bruno-garcia added Feature New feature or request Sentry labels Sep 4, 2020
@Tyrrrz
Copy link
Contributor

Tyrrrz commented Sep 28, 2020

@bruno-garcia seems like only the last point is left on the ticket.
Looking at https://docs.sentry.io/platforms/dotnet/guides/aspnet/, the only change seems to be the initialization (i.e. SentrySdk.Init(o => o.AddAspNet())), correct?
Also, how should we sync docs with the release cycle? Seeing as this change won't be in until the next major version.

@bruno-garcia
Copy link
Member Author

Good point. Maybe just leave a draft ready to be merged there? On the docs

@bruno-garcia
Copy link
Member Author

Or we could merge now the following:

Note: Version 3.0.0
We're in the processes of relasing a new package, Sentry.AspNet version 3.0.

A major difference there is which package to install and how to intitalize.

Try our latest preview package and give us feedback

Then we can merge it already and at the end just kind of move the text above and delete the note about being preview?

@Tyrrrz
Copy link
Contributor

Tyrrrz commented Sep 28, 2020

Draft PR sounds better I think.
Can you point me to the docs repo again?

@bruno-garcia
Copy link
Member Author

Sure: https://github.com/getsentry/sentry-docs/edit/master/src/platforms/dotnet/guides/aspnet/index.mdx

Tip: There's an edit this page link at the footer:
image

@Tyrrrz
Copy link
Contributor

Tyrrrz commented Sep 29, 2020

Created it here: getsentry/sentry-docs#2383

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants