Add managed attachments to native events

[TimBurik]

Package

Sentry

.NET Flavor

.NET

.NET Version

8.0.303

OS

Android

SDK Version

4.10.1

Self-Hosted Sentry Version

No response

Steps to Reproduce

1. Create an Android app and install Sentry NuGet package;
2. Configure Sentry so that reported events should have attachments (both logcat and custom attachments are affected by the issue):

SentrySdk.Init(options =>
{
    options.Dsn = "...";
    options.Android.LogCatIntegration = LogCatIntegrationType.All;
});
SentrySdk.ConfigureScope(scope =>
{
    scope.AddAttachment("path/to/existing/file.txt", AttachmentType.Default, MediaTypeNames.Text.Plain);
});

3. Generate crashes using SentrySdk.CauseCrash() with different parameters

Expected Result

All reported events should have logcat.log attachment with logcat logs and custom file.txt file attachment.

Actual Result

• Crash generated with parameter CrashType.Native is reported with mechanism signalhandler and contains no attachments;
• Crash generated with parameter CrashType.JavaBackgroundThread is reported twice: one with mechanism UncaughtExceptionHandler and contains no attachments, and another with mechanism AppDomain.UnhandledException and contains both attachments;
• All other crash types (CrashType.Managed, CrashType.ManagedBackgroundThread, CrashType.Java) are reported with mechanism AppDomain.UnhandledException and contain both attachments.

This issue might be related to #3461

Reproduction sample: SampleProject.zip

[TimBurik]

The issue is also reproduced when ApplicationNotResponding is reported, no files are attached despite both logcat and custom attachments are configured.

[jamescrosswell]

Crash generated with parameter CrashType.Native is reported with mechanism signalhandler and contains no attachments;

I think this is similar to:

• [Sentry.Maui][Android & iOS]: Native Crashes Bypass EventProcesor & BeforeSend Hook #3549

In both cases, Native crash reporting essentially skips all the .NET SDK processing.

[jamescrosswell]

Crash generated with parameter CrashType.JavaBackgroundThread is reported twice: one with mechanism UncaughtExceptionHandler and contains no attachments, and another with mechanism AppDomain.UnhandledException and contains both attachments;

I suspect the UncaughtExceptionHandler is coming from Java and the AppDomain.UnhandledException is coming from .NET.

@bitsandfoxes do you know what the expected behaviour is here?

• Should the Java SDK be syncing it's scope via a scope action callback and so should it also contain the attachments?
• Once the exception has been reported by Java, is there any way the .NET SDK could be aware of this and suppress further reporting? Or conversely, is there any way for the Java SDK to know this exception would be reported by the .NET SDK and so could safely ignore it?

[jamescrosswell]

Possibly relates to this (so maybe something that hasn't yet been implemented):

sentry-dotnet/src/Sentry/Platforms/Android/Extensions/AttachmentExtensions.cs

Lines 5 to 22 in 5fab09e

	public static SentryAttachment ToAttachment(this JavaSdk.Attachment attachment)
	{
	// TODO: Convert JavaSdk.Attachment to Sentry.Attachment.
	// One way to do this might be to serialise the JavaSdk.Attachment as
	// JSON and then deserialise it as a Sentry.Attachment. It looks like
	// Attachments aren't designed to be serialised directly though (they
	// get stuffed into EnvelopeItems instead)... and I'm not sure if we'd
	// have access to the JSON serialiser from here or how the data in
	// JavaSdk.Attachment.GetBytes() is encoded.
	throw new NotImplementedException();
	}
	public static JavaSdk.Attachment ToJavaAttachment(this SentryAttachment attachment)
	{
	// TODO: Convert Sentry.Attachment to JavaSdk.Attachment.
	// Same problem as ToAttachment() above but in reverse.
	throw new NotImplementedException();
	}

sentry-dotnet/src/Sentry/Platforms/Android/Extensions/HintExtensions.cs

Lines 13 to 16 in 5fab09e

	// TODO: Implement ToAttachment
	//dotnetHint.Screenshot = (javaHint.Screenshot is { } screenshot) ? screenshot.ToAttachment() : null;
	//dotnetHint.ViewHierarchy = (javaHint.ViewHierarchy is { } viewhierarchy) ? viewhierarchy.ToAttachment() : null;
	//dotnetHint.AddAttachments(javaHint.Attachments.Select(x => x.ToAttachment()));

[bitsandfoxes]

Once the exception has been reported by Java, is there any way the .NET SDK could be aware of this and suppress further reporting? Or conversely, is there any way for the Java SDK to know this exception would be reported by the .NET SDK and so could safely ignore it?

I might have gotten that wrong but I was under the impression that the .NET SDK would be responsible for managed code and the Java SDK would provide native support. Having the same exception reported via the UncaughtExceptionHandler in Java and the AppDomain.UnhandledException is not ideal. But the reporting SDK is part of the event details.

[jamescrosswell]

I was under the impression that the .NET SDK would be responsible for managed code and the Java SDK would provide native support.

That's true, but you can add things to the scope (including attachments) that you want/expect to be sent with both Managed and Native exceptions. This hasn't been implemented for Attachments on Android yet.