Skip to content

Allow uploading commits through set-commits #3058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bruno-garcia opened this issue Jan 17, 2024 · 1 comment · Fixed by #3462
Closed

Allow uploading commits through set-commits #3058

bruno-garcia opened this issue Jan 17, 2024 · 1 comment · Fixed by #3462
Assignees
Labels
Feature New feature or request

Comments

@bruno-garcia
Copy link
Member

bruno-garcia commented Jan 17, 2024

sentry-cli is bundled in the SDK adn invoked via msbuild

The ticket was resolved but 2 items were not completed:

But we don't upload any commit information. This would be helpful when doing a CI run for publishing a new version. For example:

dotnet publish -c Release /p:SentrySetCommits

Associating commits allows Sentry to link to source code at the correct commit sha.
image

As well as suggest suspect commits, and other features.

If we can land this on 4.0.0 we could default to making this call when msbuild publish target is running

@jamescrosswell jamescrosswell added this to the 4.0.0 milestone Jan 18, 2024
@bitsandfoxes bitsandfoxes removed this from the 4.0.0 milestone Feb 29, 2024
@bitsandfoxes bitsandfoxes added the Feature New feature or request label Apr 22, 2024
@jamescrosswell
Copy link
Collaborator

jamescrosswell commented Jul 3, 2024

Sentry CLI support

Source Link capabilities out of the box with .NET 8+

Source Link included in the .NET SDK for version 8.0 and later.

Prerequisites for .NET projects:

The following features are not available in projects that do not import Microsoft.NET.Sdk:

  • Automatic inclusion of commit SHA in AssemblyInformationalVersionAttribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants