Skip to content

Set release to -dev after publishing #2160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mattjohnsonpint opened this issue Feb 6, 2023 · 3 comments · Fixed by #3525
Closed

Set release to -dev after publishing #2160

mattjohnsonpint opened this issue Feb 6, 2023 · 3 comments · Fixed by #3525
Assignees
Labels
Feature New feature or request Repository Maintenance

Comments

@mattjohnsonpint
Copy link
Contributor

With sentry-cli, we don't want to accidentally associate release info for work-in-progress with the last shipped release. Currently, that would happen because we keep the <Version> in Directory.Build.props untouched until publishing each release.

Add a small post-release script to add a -dev tag.

@ericsampson
Copy link

The recent (.NET 8) default addition of the commit hash as part of AssemblyInformationalVersion might help address this, maybe the sentry SDK could recreate this format for older .NET SDKs/Framework

@bitsandfoxes
Copy link
Contributor

@jamescrosswell with #3462 merged, we're going to run into this issue, right?

@bitsandfoxes bitsandfoxes added the Feature New feature or request label Aug 1, 2024
@jamescrosswell
Copy link
Collaborator

@jamescrosswell with #3462 merged, we're going to run into this issue, right?

Very likely yes. At least now with SetCommits we should get specific commits associated with each release as well but it would still be misleading to associate all our dev work on release N + 1 with release N... so I think Matt's suggestion of adding some suffix like -dev or -next.wip or something makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request Repository Maintenance
Projects
Status: Done
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants