Skip to content

Commit b1e82a0

Browse files
committed
trying to find stuck test
1 parent 0c4ebc3 commit b1e82a0

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

.github/workflows/device-tests-ios.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,9 @@ jobs:
6868
continue-on-error: true
6969
run: pwsh scripts/device-test.ps1 ios -Run
7070

71-
- name: Retry Tests (if previous failed to run)
72-
if: steps.first-run.outcome == 'failure'
73-
run: pwsh scripts/device-test.ps1 ios -Run
71+
# - name: Retry Tests (if previous failed to run)
72+
# if: steps.first-run.outcome == 'failure'
73+
# run: pwsh scripts/device-test.ps1 ios -Run
7474

7575
- name: Upload results
7676
if: success() || failure()

test/Sentry.Tests/HubTests.cs

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ private class Fixture
1111
{
1212
public SentryOptions Options { get; }
1313

14-
public ISentryClient Client { get; set; }
14+
public ISentryClient Client { get; set; }
1515

1616
public ISessionManager SessionManager { get; set; }
1717

@@ -948,7 +948,7 @@ public void ContinueTrace_ReceivesHeadersAsStrings_SetsPropagationContextAndRetu
948948
SentryId.Parse("43365712692146d08ee11a729dfbcaca"), SpanId.Parse("1000000000000000"));
949949
hub.ConfigureScope(scope => scope.PropagationContext = propagationContext);
950950
var traceHeader = "5bd5f6d346b442dd9177dce9302fd737-2000000000000000";
951-
var baggageHeader ="sentry-trace_id=5bd5f6d346b442dd9177dce9302fd737, sentry-public_key=49d0f7386ad645858ae85020e393bef3, sentry-sample_rate=1.0";
951+
var baggageHeader = "sentry-trace_id=5bd5f6d346b442dd9177dce9302fd737, sentry-public_key=49d0f7386ad645858ae85020e393bef3, sentry-sample_rate=1.0";
952952

953953
hub.ConfigureScope(scope => scope.PropagationContext.TraceId.Should().Be("43365712692146d08ee11a729dfbcaca")); // Sanity check
954954

@@ -991,7 +991,7 @@ private class ThrowingProfilerFactory : ITransactionProfilerFactory
991991

992992
internal class ThrowingProfiler : ITransactionProfiler
993993
{
994-
public void Finish() {}
994+
public void Finish() { }
995995

996996
public Sentry.Protocol.Envelopes.ISerializable Collect(Transaction _) => throw new Exception("test");
997997
}
@@ -1003,7 +1003,7 @@ private class AsyncThrowingProfilerFactory : ITransactionProfilerFactory
10031003

10041004
internal class AsyncThrowingProfiler : ITransactionProfiler
10051005
{
1006-
public void Finish() {}
1006+
public void Finish() { }
10071007

10081008
public Sentry.Protocol.Envelopes.ISerializable Collect(Transaction transaction)
10091009
=> AsyncJsonSerializable.CreateFrom(CollectAsync(transaction));
@@ -1021,7 +1021,7 @@ private class TestProfilerFactory : ITransactionProfilerFactory
10211021

10221022
internal class TestProfiler : ITransactionProfiler
10231023
{
1024-
public void Finish() {}
1024+
public void Finish() { }
10251025

10261026
public Sentry.Protocol.Envelopes.ISerializable Collect(Transaction _) => new JsonSerializable(new ProfileInfo());
10271027
}
@@ -1051,7 +1051,7 @@ public void CaptureTransaction_WithSyncThrowingTransactionProfiler_DoesntSendTra
10511051
}
10521052

10531053
[Fact]
1054-
public void CaptureTransaction_WithAsyncThrowingTransactionProfiler_SendsTransactionWithoutProfile()
1054+
public async Task CaptureTransaction_WithAsyncThrowingTransactionProfiler_SendsTransactionWithoutProfile()
10551055
{
10561056
// Arrange
10571057
var transport = new FakeTransport();
@@ -1069,7 +1069,7 @@ public void CaptureTransaction_WithAsyncThrowingTransactionProfiler_SendsTransac
10691069

10701070
// Act
10711071
hub.StartTransaction("foo", "bar").Finish();
1072-
hub.FlushAsync().Wait();
1072+
await hub.FlushAsync();
10731073

10741074
// Assert
10751075
transport.GetSentEnvelopes().Should().HaveCount(1);
@@ -1088,7 +1088,7 @@ public void CaptureTransaction_WithAsyncThrowingTransactionProfiler_SendsTransac
10881088
}
10891089

10901090
[Fact]
1091-
public void CaptureTransaction_WithTransactionProfiler_SendsTransactionWithProfile()
1091+
public async Task CaptureTransaction_WithTransactionProfiler_SendsTransactionWithProfile()
10921092
{
10931093
// Arrange
10941094
var transport = new FakeTransport();
@@ -1106,7 +1106,7 @@ public void CaptureTransaction_WithTransactionProfiler_SendsTransactionWithProfi
11061106

11071107
// Act
11081108
hub.StartTransaction("foo", "bar").Finish();
1109-
hub.FlushAsync().Wait();
1109+
await hub.FlushAsync();
11101110

11111111
// Assert
11121112
transport.GetSentEnvelopes().Should().HaveCount(1);
@@ -1452,7 +1452,7 @@ public void CaptureTransaction_HubEnabled(bool enabled)
14521452
transaction.Finish();
14531453

14541454
// Assert
1455-
_fixture.Client.Received().CaptureTransaction(Arg.Is<Transaction>(t => t.IsSampled == enabled),Arg.Any<Scope>(), Arg.Any<Hint>());
1455+
_fixture.Client.Received().CaptureTransaction(Arg.Is<Transaction>(t => t.IsSampled == enabled), Arg.Any<Scope>(), Arg.Any<Hint>());
14561456
}
14571457

14581458
[Fact]

0 commit comments

Comments
 (0)