-
-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default log level to warning #4467
Comments
related: getsentry/sentry-native#888 |
@philprime, we still should change the default log level to warning. #4707 only changes always logging fatal message. I would like to keep this open. |
I just saw that PR, i'm not sure I'd overload a level to essentially indicate "ignore levels", and instead would have added another config parameter like |
@armcknight not sure if I understand your proposition. In my PR the logAlwaysLevel is defined as a constant and can not be configured. |
Description
The default SDK log level is debug. When you turn on
option.debug = true
the SDK logs too much information, so warnings and errors get lost. Instead the SDK should log only warnings and above whenoption.debug = true
. Users can manually set thediagnosticLevel
to debug if required. When we detect a debug build, we turn on debug = true, so you get only the warnings and errors. We still need to discuss if we're going to handle this as a breaking change or not, and we should create a meta issue for this to align across all SDKs.This is also required to surface severe SDK misconfiguration or other errors clearly to the user such as: #4566
🛑 Blocked by
The text was updated successfully, but these errors were encountered: